Bug 8161 - Cataloging home page should be accessible to users with permission to edit catalog or edit items
Summary: Cataloging home page should be accessible to users with permission to edit ca...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 8160
  Show dependency treegraph
 
Reported: 2012-05-29 16:08 UTC by Owen Leonard
Modified: 2013-12-05 19:59 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8161 - Cataloging home page should be accessible to users with permission to edit catalog or edit items (3.52 KB, patch)
2012-05-29 16:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 8161 - Cataloging home page should be accessible to users with permission to edit catalog or edit items (3.59 KB, patch)
2012-05-29 17:31 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2012-05-29 16:08:56 UTC
Currently the cataloging home page (addbooks.pl)requires edit_catalog permission. The page should be accessible to users who have either edit_catalog permission, edit_items permission, or both. Links on the page should be shown or hidden based on those permissions.
Comment 1 Owen Leonard 2012-05-29 16:48:29 UTC Comment hidden (obsolete)
Comment 2 Jared Camins-Esakov 2012-05-29 17:31:18 UTC
Created attachment 9839 [details] [review]
Bug 8161 - Cataloging home page should be accessible to users with permission to edit catalog or edit items

This patch modifies the permissions required to access the cataloging
home page (addbooks.pl) so that the user requires edit_catalogue,
edit_items, or fast_cataloging permission.

Users with only edit_catalogue permission will only see biblio edit
links. Users with edit_items permission will only see item edit
links. Users with fast_cataloging permission will only be able to
view information about contents of the catalog--useless for them
but I'm not sure how better to handle it.

To test, log in as a user with each of the above permissions
enabled separately and in combination and test access.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Comment 3 Ian Walls 2012-06-04 20:19:38 UTC
Generalizes permissions slightly to cover more cases of valid users, then uses permissions to hide unusable links in the template.  Marking Passed QA.
Comment 4 Chris Cormack 2012-06-06 05:35:14 UTC
Pushed to 3.8.x, will be in 3.8.2