Enhancement: when checking in for a restricted patron, display of a warning telling about this status.
Created attachment 10206 [details] [review] proposed patch #1 Rebased a patch from Lyon3 working on this.
Patch applies ok, but uses format_date instead of using the KohaDates plugin. Signing off but adding a follow to fix the date formatting. Follow up still needs signoff
Created attachment 10584 [details] [review] Bug 8231 : Follow to fix date formatting
Created attachment 10585 [details] [review] [SIGNED-OFF] Bug 8231: reminder when checking in for a restricted patron If a patron is restricted, a warning will appear on the return page when checking in. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 10586 [details] [review] Bug 8231 : Follow to fix date formatting
Why are there two different ways of handling restrictions? I see references to "Debarred" and "PrevDebarred." Are these for different cases? Under what circumstances is the "Debarred" message displayed? If they cannot be consolidated the new message should use the same format as the other one, naming and linking to the patron record. The message should also differentiate between a basic restriction (no specific date) and restricted until. In the former case the staff client should not say "restricted until 12/31/9999."
Adrien, could you please address Owen's questions?
Created attachment 15332 [details] [review] Bug8231 Systematic warning at check in if borrower is restricted Patch redone : It displays a different warning (from the actual one) when an already restricted borrower checks in a document and : the document is late but don't diserve an extra restriction the document is not late. (in the code 'PrevDebarred' match both case) In the last one, that may enable the librarian to inform immediately the borrower of his situation (borrowers are not always very up-todate about the state of their loans). Test plan : 1) Apply the patch 2) Go to a borrower checkout page and checkout some documents with different passed duedate using "Specify due date" function. Checkout out one with the default duedate. 3) Check in the document with the bigger delay : You will get the message : 'X is now restricted until ...' 4) Check in one of the document with a smaller delay : You 'll get a different message : 'Reminder : Patron was earlier restricted untill...' 5) Check in the document which is not late : You 'll get the same message as the previous one I tried to get the english for the french form : 'Rappel : Le lecteur a été précédemment suspendu jusqu'au' but I'm not sure to have really found the equivalent. It's only a question to make clear that the suspension is not necessarly bound with the document beeing checked. Olivier Crouzet
Well, I put my proper patch in discussion because there is a big error (sigh...) in it.
Created attachment 16263 [details] [review] Bug 8231 Systematic warning at check in if borrower is restricted It's ok now with this new patch : see Comment 8 for test plan
Seems to work as it should, except for one thing: The warning about the patron being restricted is in a box with the heading "Cannot check in." This implies the check-in did not complete successfully, which isn't true. I'm not sure how to word the restriction warning better. My only alternative suggestion is "Patron is still restricted until 04/03/2013"
The warning problem you mentionned is preexisting. I have opened a new bogue for it (bug 9860)
Created attachment 17273 [details] [review] Bug 8231 Systematic warning at check in if borrower is restricted To test this new patch, it 's necessary to first apply the bug 9860 patch that corrects the Cannot check in problem See Test plan in comment 8.
Created attachment 18077 [details] [review] Bug 8231 Systematic warning at check in if borrower is restricted I submit again this patch now that bug 9031 is fixed.
This patch needs a SO.
Hello, I would like to test the patch but after the first test I have no messages displayed. Compared to the test plan, it is there to add information. thank you
?! I redid tests and it's ok for me. I have first the 'is now debarred until' message and then the 'Reminder: Patron was earlier restricted until' message for the following checkin with shorter late. Are you sure of your test ? Olivier Crouzet
When testing on a sandbox, I have no message when check in. Items is late with different passed duedate, a patron is debarred, but no message. There he has a preference system to activate ? Notifications are active for check out and check in. Thank you for your information
Bonjour Cédric, No there's no syspref to activate nor updatedatabase to do, but I repeat it works on our test instance. Anyhow you should have at least the already existing message 'is now debarred until'. Do you have this one without the patch ? Olivier
Created attachment 20581 [details] [review] [SIGNED-OFF] Bug 8231 Systematic warning at check in if borrower is restricted Display, at check in, a reminder of an already existing suspension date even if the returned document is not late Test plan : 1) Apply the patch 2) Go to a borrower checkout page and checkout some documents with different passed duedate using "Specify due date" function. Checkout out one with the default duedate. 3) Check in the document with the bigger delay : You will get the message : 'X is now restricted until ...' 4) Check in one of the document with a smaller delay : You'll get a different message : 'Reminder : Patron was earlier restricted until...' 5) Check in the document which is not late : You'll get the same message as the previous one Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 21080 [details] [review] Bug 8231 Systematic warning at check in if borrower is restricted Display, at check in, a reminder of an already existing suspension date even if the returned document is not late Test plan : 1) Apply the patch 2) Go to a borrower checkout page and checkout some documents with different passed duedate using "Specify due date" function. Checkout out one with the default duedate. 3) Check in the document with the bigger delay : You will get the message : 'X is now restricted until ...' 4) Check in one of the document with a smaller delay : You'll get a different message : 'Reminder : Patron was earlier restricted until...' 5) Check in the document which is not late : You'll get the same message as the previous one Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> It seems consistent to display the restriction alert even if the user is already debarred.
This patch no longer applies. This is more than just a merge conflict; the change in the restriction introduced for bug 2720 should be taken into account.
Created attachment 22883 [details] [review] Bug 8231 Systematic warning at check in when borrower is debarred Patch redone taking into account changes introduced by bug 2720. Olivier Crouzet
Hello Tested on sandbox biblibre 1. It works ! Maybe you had forgotten to tell in your testplan that u need to have suspension in days set in your issuing rules for this feature to work. Thanks.
(In reply to Koha Team Lyon 3 from comment #23) > Created attachment 22883 [details] [review] [review] > Bug 8231 Systematic warning at check in when borrower is debarred > > Patch redone taking into account changes introduced by bug 2720. Olivier, Your last past does not include the DateTime->compare test, is it intended?
Team Lyon, there is an open question from Jonathan in comment 25 - could you please take a look? :)
Created attachment 24220 [details] [review] Bug 8231 Systematic warning at check in if borrower is restricted very good question Jonathan : yes it was intended because I thought it was no more necesary but it is indeed. I put back the comparison. Olivier Crouzet
Hi Olivier, The last patch has not been signed off, I switch the status back accordingly.
Patch tested with a sandbox, by JMBroust <jean-manuel.broust@univ-lyon2.fr>
Created attachment 24230 [details] [review] Bug 8231 Systematic warning at check in if borrower is restricted Display, at check in, a reminder of an already existing suspension date even if the returned document is not late Signed-off-by: JMBroust <jean-manuel.broust@univ-lyon2.fr>
It works as before the rebase, no regression found. Marked as Passed QA.
Created attachment 24273 [details] [review] Bug 8231 Systematic warning at check in if borrower is restricted Display, at check in, a reminder of an already existing suspension date even if the returned document is not late Test plan : 1) Apply the patch 2) Go to a borrower checkout page and checkout some documents with different passed duedate using "Specify due date" function. Checkout out one with the default duedate. 3) Check in the document with the bigger delay : You will get the message : 'X is now restricted until ...' 4) Check in one of the document with a smaller delay : You 'll get a different message : 'Reminder : Patron was earlier restricted untill...'. 5) Check in the document which is not late : You 'll get the same message as the previous one Signed-off-by: JMBroust <jean-manuel.broust@univ-lyon2.fr> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master. Thanks, Olivier!