Bug 8062 corrected a bug on sending basket by email. But it corrects only OPAC. Same problem exists in intranet. Same problem exists for sending list by email, reported by bug 8368.
Hi Fridolyn, please also take a look at bug 10605 - it's still waiting for a sign off (*hint*) and a correction to the encoding that will also be needed for the intranet I think :)
Created attachment 21847 [details] [review] Bug 9218: intranet cart email broken for non english templates While bug 9189 is not resolved, we have to find workaround for templates broken by missing carriage return. This (dirty) patch adds a personal tag "PARAGRAPH" for adding new lines. Test plan: - add somes notices to the cart - try to send the cart by email - the email should be the same as before - translate templates and retry with another language. Before this patch, the email was empty. With this patch, it contains the list of records and items.
Hi Jonathan, hm not sure, but why not copy the OPAC solution 1:1? I think normal HTML is used there and stripped out using some TT magic: 5 [% USE HtmlToText %] 6 [% myhtml FILTER html2text(leftmargin => 0, rightmargin => 0) %] 7 [% myhtmltext | html2text %] http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/opac-tmpl/prog/en/modules/opac-sendbasket.tt;h=dc6929da2c3b357f92d90af5ef6f505152bf3bd6;hb=b9c85431ddf967ecadf88ee9d2cbe14ac95d5be4
(In reply to Katrin Fischer from comment #3) > Hi Jonathan, > > hm not sure, but why not copy the OPAC solution 1:1? Pfff, I don't know... quick_and_dirty--
Created attachment 21869 [details] [review] Bug 9218: intranet cart email broken for non english templates This patch adapts the method from OPAC to the staff interface (cf bug 8062). Test plan: - add somes notices to the cart - try to send the cart by email - the email should be the same as before - translate templates and retry with another language. Before this patch, the email was empty. With this patch, it contains the list of records and items.
Created attachment 21874 [details] [review] intranet cart email broken for non english templates
I sign off the patch
Created attachment 22136 [details] [review] [PASSED QA] Bug 9218: intranet cart email broken for non english templates This patch adapts the method from OPAC to the staff interface (cf bug 8062). Test plan: - add somes notices to the cart - try to send the cart by email - the email should be the same as before - translate templates and retry with another language. Before this patch, the email was empty. With this patch, it contains the list of records and items. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Passes all tests and QA script. Fixes quite a bad translation problem, tested with German templates and umlauts in the message and records.
Pushed to master. Thanks, Jonathan!
This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Jonathan!
Will it be in 3.10.x too ?
The 'à' character I write in my message (in .po file) or in the comment are not encoded correctly and shows as � even with that patch. It's weird because this seems to be only with that character Other characters (î ç ï û) are ok. Anyone noticed that ?