Created attachment 11719 [details]
opac display

This patch does not apply on current master. it seems the commit that updated master was a long time ago (30f4b815, in february). Was the patch made against 3.8 ?
Anyway, please rebase & resubmit.

QA comment
 * patch related to xsl only
 * passes koha-qa.pl
 * introduces some string changes

passed QA, but I won't push it for 3.10

This patch does not play well with the authority links added by bug 8210. Specifically, the punctuation ends up floating in between the term and the magnifying glass icon. Once this is resolved, I am ready to push this patch.

After applying this patch, in the OPAC I can now see: 
Additional author(s): Gordon, Rachel Singer [magnifying glass icon].

The "By" has correctly been changed to "Additional author(s)" instead, and the punctuation appears to be fixed as well.  I'm signing off!

Created attachment 13816 [details]
screenshot

Hi Owen,
I think the space between relator code ($4) and the author's name is missing.

Added a space. I hope it's okay that I've left it as 'signed-off.'

Katrin, you're better than I'm for MARC21, so I let you QA this patch, as you seem to have started in comment 12

Hi Owen,

I am sorry, the patch does no longer apply :( Could you please rebase? I was also wondering about the HTML entities in those 2 lines:

        <xsl:choose>
          <xsl:when test="position()&gt;1"/>
          <xsl:when test="@tag&lt;700">Author(s): </xsl:when>

Please switch back to signed off after rebasing.

(In reply to comment #16)
> I was also wondering about the HTML entities in those 2 lines:
> 
>         <xsl:choose>
>           <xsl:when test="position()&gt;1"/>
>           <xsl:when test="@tag&lt;700">Author(s): </xsl:when>

All I know about that is that it exists in the staff client XSL from which I copied.

A few notes about this feature:

1) I am not a big fan about the punctuation at the end, I think for the normal OPAC user this does not look right (given you don't know about MARC and all that). Plus: they are explicitly added and not in my data.

+          <xsl:when test="position()=last()"><xsl:text>.</xsl:text></xsl:when><xsl:otherwise

2) Author(s) - the way we indicate plural/singular here is not used for any other label. For the other labels we just use plural form or singular. So this is a bit inconsistent.

3) I would love if it would be possible to hide the [edt] and similar from display. The codes are not translatable and a lot of them are not an easy guess for a normal user.

Bad news. I think I need to fail this patch pending a follow-up that addresses Katrin's point 3 (repeated below, with some commentary).

(In reply to comment #19)
> 2) Author(s) - the way we indicate plural/singular here is not used for any
> other label. For the other labels we just use plural form or singular. So
> this is a bit inconsistent.

I agree with Katrin, and since there will only ever be one Author, I think at the very least we could change that to Author instead of Author(s). I would favor changing "Additional author(s)" to "Additional authors," too, but that's open for argument.

> 3) I would love if it would be possible to hide the [edt] and similar from
> display. The codes are not translatable and a lot of them are not an easy
> guess for a normal user.

Without this patch we have a span to make this possible: <a href="/cgi-bin/koha/opac-search.pl?q=au:Fernandes,%20Eugenie,">Fernandes, Eugenie<span class="relatorcode"> [ill.]</span></a>

The span should be kept when breaking out the authors.

Sorry, I give up on this. I can't untangle the necessary changes now that the OPAC version has had so many revisions. I hope someone else can solve this one.

With the changes made for RDA on the XSLT, this is fixed and the display between staff and OPAC is the same now.