Bug 8851 - strange blue bar above serials results
Summary: strange blue bar above serials results
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact:
URL: cgi-bin/koha/serials/serials-search.p...
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-01 13:31 UTC by Nicole C. Engard
Modified: 2014-05-26 21:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
search heading (115.75 KB, image/png)
2012-10-01 13:31 UTC, Nicole C. Engard
Details
Bug 8851 - strange blue bar above serials results (4.85 KB, patch)
2012-10-02 18:40 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8851 - strange blue bar above serials results (4.88 KB, patch)
2012-10-02 18:53 UTC, Nicole C. Engard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2012-10-01 13:31:27 UTC
Created attachment 12621 [details]
search heading

See attached.

When doing a serials search there is a strange looking header bar at the top.
Comment 1 Katrin Fischer 2012-10-01 16:53:56 UTC
Hi Nicole,

this is the new advanced search. It will unfold when you click on the label.
Comment 2 Owen Leonard 2012-10-02 18:40:16 UTC Comment hidden (obsolete)
Comment 3 Nicole C. Engard 2012-10-02 18:53:19 UTC
Created attachment 12650 [details] [review]
[SIGNED-OFF] Bug 8851 - strange blue bar above serials results

Bug 5357 (Subscription search and displays) added an advanced
search form which adds a new interface featured: a collapsible
fieldset with the search form inside. Bug 8851 was filed
because it is not immediately obvious that the search form
is hidden and can be shown by clicking the fieldset's legend.

I contend that this new behavior is unnecessary: In many other
places we put a similar search form in the left-hand sidebar.

This patch amends the template to show the search form in the
main body of the page if no search has been performed. After
searching the form is moved to the sidebar. This keeps the page
consistent with other interfaces and eliminates the confusion
about the collapsed form.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Comment 4 Paul Poulain 2012-10-12 19:35:21 UTC
QA comment:
 * small patch, template only, mostly moves something to the left
 * koha-qa.pl OK

passed QA
Comment 5 Paul Poulain 2012-10-12 19:35:38 UTC
Patch pushed to master
Comment 6 Chris Cormack 2012-10-14 07:34:10 UTC
Doesn't apply to 3.8.x
Comment 7 Chris Cormack 2013-04-21 00:47:37 UTC
If you wish this to be in 3.8.x please attach a patch for 3.8.x otherwise please mark this fixed