Bug 8860 - can't merge if you don't have fast cataloging permissions
Summary: can't merge if you don't have fast cataloging permissions
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low critical (vote)
Assignee: Kyle M Hall
QA Contact: Mason James
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-02 12:38 UTC by Nicole C. Engard
Modified: 2019-06-27 09:24 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8860 - can't merge if you don't have fast cataloging permissions (1.02 KB, patch)
2012-10-02 13:25 UTC, Kyle M Hall
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8860 - can't merge if you don't have fast cataloging permissions (1.08 KB, patch)
2012-10-02 15:17 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2012-10-02 12:38:14 UTC
A couple of libraries so far have reported that they are unable to merge records through the Lists feature. They can create a list, add records to it, and select two records to merge without a problem, but when they get to the Merge Reference screen and click Next, they get logged out of koha and put back to the Login screen with an error. When logging back in, they get the error message "an unexpected number of records was provided for merging. Currently only two records at a time can be merged."  

They have only selected two records for merging but they still receive this message. 

We have tested this in 3.8 and master and in Chrome, Firefox and IE.  It actually works in IE, but doesn't in FF or Chrome (the browsers we tell people to use for the staff client).  It turns out this happens to users who have edit catalog and edit items permission but not fast cataloging permissions.  You shouldn't need fast cataloging permissions to merge items, all it should require is edit catalog and edit items.

Also, the error message is misleading since it's a permissions issue and not an issue with the number of items you're merging.
Comment 1 Kyle M Hall 2012-10-02 13:25:08 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2012-10-02 15:17:28 UTC
Created attachment 12646 [details] [review]
[SIGNED-OFF] Bug 8860 - can't merge if you don't have fast cataloging permissions

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Owen Leonard 2012-10-02 15:23:22 UTC
(In reply to comment #0)
> Also, the error message is misleading since it's a permissions issue and not
> an issue with the number of items you're merging.

By the way, the error message has nothing to do with the bug itself. The error message arises because after you're logged out and forced to log in again the merge operation has lost the original two records you asked to merge. That's why it complains about the number of items (which is 0)
Comment 4 Mason James 2012-10-03 21:23:44 UTC
(In reply to comment #2)
> Created attachment 12646 [details] [review]
> [SIGNED-OFF] Bug 8860 - can't merge if you don't have fast cataloging
> permissions
> 
> Signed-off-by: Owen Leonard <oleonard@myacpl.org>

patch looks good, passing QA

$ koha-qa.pl -c 1

testing 1 commit(s) (applied to commit 50be765)
 * f1691e0 Bug 8860 - can't merge if you don't have fast cataloging permissions
      cataloguing/merge_ajax.pl

* cataloguing/merge_ajax.pl                                                OK
Comment 5 Paul Poulain 2012-10-05 14:53:29 UTC
Patch pushed to master
Comment 6 Chris Cormack 2013-04-20 23:17:54 UTC
Pushed to 3.8.x will be in 3.8.12