Created attachment 12720 [details] opacheader to the right of search In CCSR the opacheader preference isn't really in the header it's to the right of the search box (see attached). I'm okay with a customizable region over there, but we should have a new preference for that and header should be above the search box as it implies
Changing assignee to Frédérick since he originally designed the theme and can probably fix this.
(In reply to comment #1) > Changing assignee to Frédérick since he originally designed the theme and > can probably fix this. Could you please remove Fréférick from all the ccsr tickets. He didn't design the theme (he did the mobile part and someone else from libeo and me did the rest) and he is not working anymore on Koha, so he won't be able to fix those bugs. I will do my best to get some time to look at those bugs, but they are all very easy to fix, so no need to assign them. Thanks.
Assignee changed per comment on bug 8884.
Changing assignee back to default because i'm not able to fix any ccsr theme bug as we don't use it yet.
Created attachment 18261 [details] [review] Bug 8884: opacheader is not in the header on CCSR In CCSR the opacheader preference isn't really in the header it's to the right of the search box (see attached). I'm okay with a customizable region over there, but we should have a new preference for that and header should be above the search box as it implies. To test: 1) Put something in the OpacHeader syspref. Preferably something large and header-like for maximum effect. 2) Select CCSR theme. 3) View OPAC. Notice placement of "header" content. 4) Apply patch. 5) View OPAC. Notice placement of "header" content. 6) Sign off.
Jared, I am going to test this but would like to make a suggestion. There are a few sites I am already working with and will be using the opacheader to place a library logo to the right of the search bar as it is functioning now. So if this passes QA and gets patched it will affect these sites. Might we be able to add a new system preference to work like the opacheader is working now on CCSR to accomodate this desired look? Just a thought. Ed
(In reply to comment #6) > There are a few > sites I am already working with and will be using the opacheader to place a > library logo to the right of the search bar as it is functioning now. Is that because that's where they really want it, or because that's where they can put it? I would certainly prefer to fix the placement of opacheader and have any library customizations be corrected later. There will be plenty of notice before any such change arrives on customers' installations.
Owen, Yes, I agree and that is what I was trying to say. I would like to opacheader work as it should and then add a new preference or just figure out a way to move the logos there. I was just bouncing around the idea. Ed
Maybe we could just copy from opacheader into the new preference on database update and preserve the current customizations that way?
(In reply to comment #9) > Maybe we could just copy from opacheader into the new preference on database > update and preserve the current customizations that way? Wouldn't copying over the contents of 'opacheader' to a new preference cause a bit of a surprise (in the form of duplicate text or the like) for libraries that aren't using CCSR? Also, that begs the question of whether a new system preference is needed -- shifting logos around could be done via OpacUserCSS, and at the moment I'm not convinced that we need to maintain backwards compatibility for what appears to simply have been an oversight.
Created attachment 18396 [details] [review] Bug 8884: opacheader is not in the header on CCSR In CCSR the opacheader preference isn't really in the header it's to the right of the search box (see attached). I'm okay with a customizable region over there, but we should have a new preference for that and header should be above the search box as it implies. To test: 1) Put something in the OpacHeader syspref. Preferably something large and header-like for maximum effect. 2) Select CCSR theme. 3) View OPAC. Notice placement of "header" content. 4) Apply patch. 5) View OPAC. Notice placement of "header" content. 6) Sign off. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 19018 [details] [review] Bug 8884: opacheader is not in the header on CCSR In CCSR the opacheader preference isn't really in the header it's to the right of the search box (see attached). I'm okay with a customizable region over there, but we should have a new preference for that and header should be above the search box as it implies. To test: 1) Put something in the OpacHeader syspref. Preferably something large and header-like for maximum effect. 2) Select CCSR theme. 3) View OPAC. Notice placement of "header" content. 4) Apply patch. 5) View OPAC. Notice placement of "header" content. 6) Sign off. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, works as advertised with one caveat; the content of opacheader is by default underneath the div "top-bar". A couple breaks in my OpacHeader test made it visible, so I'm going to assume this is a styling issue and not a bug as such.
(In reply to comment #12) > works as advertised with one caveat; the content of > opacheader is by default underneath the div "top-bar". A couple breaks > in my OpacHeader test made it visible, so I'm going to assume this is a > styling issue and not a bug as such. Indeed, a little CSS to add margin-top or padding-top to opac-custom-header would take care of moving it, but that would be a little unfriendly to a user who just wants to add a custom header without having to immediately wonder why the top bar overlaps it. I'll shortly be attaching a follow-up patch for consideration.
Created attachment 19027 [details] [review] Bug 10245: add CSS classes to OPAC detail items table header Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Classes now appear on <th> as well for easy styling. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, template changes only. Adds classes and id's to table headers, makes no other changes. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 19028 [details] [review] Bug 8884: opacheader is not in the header on CCSR In CCSR the opacheader preference isn't really in the header it's to the right of the search box (see attached). I'm okay with a customizable region over there, but we should have a new preference for that and header should be above the search box as it implies. To test: 1) Put something in the OpacHeader syspref. Preferably something large and header-like for maximum effect. 2) Select CCSR theme. 3) View OPAC. Notice placement of "header" content. 4) Apply patch. 5) View OPAC. Notice placement of "header" content. 6) Sign off. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, works as advertised with one caveat; the content of opacheader is by default underneath the div "top-bar". A couple breaks in my OpacHeader test made it visible, so I'm going to assume this is a styling issue and not a bug as such. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 19029 [details] [review] Bug 8884: (follow-up) rearrange placement of the top-bar div in CCSR This patch makes it easier to avoid having the top bar overlap other OPAC page content (particularly custom header content set via the opacheader system preference). This is done by moving the top-nav div outside of the main doc3 div and adjusting the CSS accordingly. Yes, this does end up having top-nav.inc be included from opac-bottom.inc, but it would require touching rather more templates to have it be included immediately after the <body> tag. This patch also removes a duplicate instance of the cmspan span. To test: [1] Change to the CCSR OPAC theme. [2] Before applying the patch, open a set of OPAC pages (e.g., main page, user page, search results, bib details) in your web browser. [3] Apply the patch, and open the same OPAC pages in separate tabs. Comparing the pre- and post- version of each page to verify that the placement [4] Add an OpAC header using the opacheader system preference. [5] Verify that the header is displayed without overlapping the top bar. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
I've set the status back to needs-signoff, but please note that it's my follow-up patch that is need of additional review.
Created attachment 19198 [details] [review] Bug 8884: (follow-up) rearrange placement of the top-bar div in CCSR This patch makes it easier to avoid having the top bar overlap other OPAC page content (particularly custom header content set via the opacheader system preference). This is done by moving the top-nav div outside of the main doc3 div and adjusting the CSS accordingly. Yes, this does end up having top-nav.inc be included from opac-bottom.inc, but it would require touching rather more templates to have it be included immediately after the <body> tag. This patch also removes a duplicate instance of the cmspan span. To test: [1] Change to the CCSR OPAC theme. [2] Before applying the patch, open a set of OPAC pages (e.g., main page, user page, search results, bib details) in your web browser. [3] Apply the patch, and open the same OPAC pages in separate tabs. Comparing the pre- and post- version of each page to verify that the placement [4] Add an OpAC header using the opacheader system preference. [5] Verify that the header is displayed without overlapping the top bar. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Pushed to master along with the follow-up. Thanks, Jared!
This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Jared!
First patch pushed to 3.10.x, will be in 3.10.8 Second does not apply.