Bug 8949 - Trying to view help on a page without any help results in a Perl error
Summary: Trying to view help on a page without any help results in a Perl error
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low normal (vote)
Assignee: Paul Poulain
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-20 00:36 UTC by Jared Camins-Esakov
Modified: 2013-12-05 20:06 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8949: Trying to view help on a page without any help results in a nasty error (1.60 KB, patch)
2012-11-02 10:20 UTC, Paul Poulain
Details | Diff | Splinter Review
Bug 8949: Trying to view help on a page without any help results in a nasty error (1.67 KB, patch)
2012-11-02 12:13 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Camins-Esakov 2012-10-20 00:36:32 UTC

    
Comment 1 Paul Poulain 2012-11-02 09:53:09 UTC
example page: /cgi-bin/koha/acqui/addorderiso2709.pl (reached from acqui > basket > Add order to basket From a staged file
Comment 2 Paul Poulain 2012-11-02 09:55:06 UTC
mmm... this bug is not specific to Plack. In CGI mode you also get a nasty
Template process failed: file error - /home/paul/koha.dev/koha-community/koha-tmpl/intranet-tmpl/prog/en/modules/help/acqui/addorderiso2709.tt: not found at /home/paul/koha.dev/koha-community/C4/Templates.pm line 132.
Comment 3 Paul Poulain 2012-11-02 10:20:07 UTC Comment hidden (obsolete)
Comment 4 Jared Camins-Esakov 2012-11-02 12:13:11 UTC
Created attachment 13203 [details] [review]
Bug 8949: Trying to view help on a page without any help results in a nasty error

The problem was probably a side effect of bug 7038

I've checked that things are OK in translated languages.

Test plan:
 * open help on a page with help in english (mainpage.pl)
 * open help on a page with help in another language (mainpage.pl)
=> you'll see the online help, as usual
 * open help on a page without help in english (acqui/addorderiso2709.pl)
 * open help on a page without help in another language (acqui/addorderiso2709.pl)
=> you'll get the "oops, no help available, sorry", no more the Perl error

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Comment 5 Jonathan Druart 2012-11-05 09:56:38 UTC
QA Comments:
The patch works as expected.
Note: The "Add help" button does not work.

Marked as Passed QA.
Comment 6 Jared Camins-Esakov 2012-11-05 13:49:54 UTC
This patch has been pushed to master.
Comment 7 Paul Poulain 2012-11-05 15:58:25 UTC
Patch pushed to branch 3.10.x
Comment 8 Chris Cormack 2013-04-21 11:10:14 UTC
Released in 3.10.0