Bug 8986 - Batch patron modification template corrections
Summary: Batch patron modification template corrections
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
: 8960 (view as bug list)
Depends on: 8980
Blocks: 11245
  Show dependency treegraph
 
Reported: 2012-10-30 12:56 UTC by Owen Leonard
Modified: 2013-11-13 15:29 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8986 - Batch patron modification template corrections (13.01 KB, patch)
2012-10-30 13:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 8986 [Revised] Batch patron modification template corrections (12.48 KB, patch)
2012-11-01 14:03 UTC, Owen Leonard
Details | Diff | Splinter Review
[Signed off] Bug 8986 [Revised] Batch patron modification template corrections (12.50 KB, patch)
2012-11-08 19:44 UTC, Melia Meggs
Details | Diff | Splinter Review
Bug 8986: Followup FIX a JS error if there is no valid card number (3.07 KB, patch)
2012-11-19 16:13 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 8986: Followup FIX a JS error if there is no valid card number (3.28 KB, patch)
2012-11-19 16:53 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2012-10-30 12:56:19 UTC
The batch patron modification template has lots of minor errors which need to be corrected: incorrect case, incorrect terminology, copy and paste errors.
Comment 1 Owen Leonard 2012-10-30 13:55:52 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2012-10-30 13:56:33 UTC
Note to testers: Depends on the patch for Bug 8980.
Comment 3 Owen Leonard 2012-10-30 14:00:14 UTC
Comment on attachment 13116 [details] [review]
Bug 8986 - Batch patron modification template corrections

Whoops--something in my patch has created a bug in cloning patron attributes.
Comment 4 Owen Leonard 2012-11-01 14:03:22 UTC Comment hidden (obsolete)
Comment 5 Jared Camins-Esakov 2012-11-01 19:43:10 UTC
String changes. Will hold for post-3.10.0.
Comment 6 Melia Meggs 2012-11-08 19:44:21 UTC
This looks much prettier!  Things are properly aligned and spelled and capitalized correctly.  Card number link to patron details page works.  Table sorter works.  I made two batch patron modifications, and everything worked as expected.

I think this is an improvement, so I am adding my sign off.
Comment 7 Melia Meggs 2012-11-08 19:44:57 UTC
Created attachment 13320 [details] [review]
[Signed off] Bug 8986 [Revised] Batch patron modification template corrections

Many minor template changes:

- Correcting title and headings
- Adding translation to string in JavaScript
- Tweaking table sorter
- Wrapping card number in link to patron detail page
- Adding standard styles to "clear" links (see patron attributes)
- Terminiology corrections (borrower-> patron, cardnumber -> card number)
- Capitalization corrections
- Improve display of extended attributes

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Comment 8 Jonathan Druart 2012-11-19 16:13:42 UTC Comment hidden (obsolete)
Comment 9 Jonathan Druart 2012-11-19 16:15:36 UTC
QA Comment:

Thanks Owen for this patch!

I proposed a followup: if no card number is valid, a javascript error is raised. The patch hides the table and some javascript functions if the table is empty.
Comment 10 Owen Leonard 2012-11-19 16:53:11 UTC
Created attachment 13533 [details] [review]
Bug 8986: Followup FIX a JS error if there is no valid card number

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

I can't reproduce the JS error but the template changes are correct
with regard to how the page should handle errors.
Comment 11 Jonathan Druart 2012-11-20 10:25:14 UTC
This patch fixes some minors template errors in tools/modborrowers.tt

Marked as Passed QA.
Comment 12 Jonathan Druart 2012-11-20 12:54:49 UTC
*** Bug 8960 has been marked as a duplicate of this bug. ***
Comment 13 Jared Camins-Esakov 2012-11-23 18:43:27 UTC
This patch has been pushed to master.
Comment 14 Chris Cormack 2012-11-26 03:02:44 UTC
Pushed to 3.10.x will be in 3.10.1