The batch patron modification template has lots of minor errors which need to be corrected: incorrect case, incorrect terminology, copy and paste errors.
Created attachment 13116 [details] [review] Bug 8986 - Batch patron modification template corrections Many minor template changes: - Correcting title and headings - Adding translation to string in JavaScript - Tweaking table sorter - Wrapping card number in link to patron detail page - Adding standard styles to "clear" links (see patron attributes) - Terminiology corrections (borrower-> patron, cardnumber -> card number) - Capitalization corrections - Make labels clickable
Note to testers: Depends on the patch for Bug 8980.
Comment on attachment 13116 [details] [review] Bug 8986 - Batch patron modification template corrections Whoops--something in my patch has created a bug in cloning patron attributes.
Created attachment 13175 [details] [review] Bug 8986 [Revised] Batch patron modification template corrections Many minor template changes: - Correcting title and headings - Adding translation to string in JavaScript - Tweaking table sorter - Wrapping card number in link to patron detail page - Adding standard styles to "clear" links (see patron attributes) - Terminiology corrections (borrower-> patron, cardnumber -> card number) - Capitalization corrections - Improve display of extended attributes
String changes. Will hold for post-3.10.0.
This looks much prettier! Things are properly aligned and spelled and capitalized correctly. Card number link to patron details page works. Table sorter works. I made two batch patron modifications, and everything worked as expected. I think this is an improvement, so I am adding my sign off.
Created attachment 13320 [details] [review] [Signed off] Bug 8986 [Revised] Batch patron modification template corrections Many minor template changes: - Correcting title and headings - Adding translation to string in JavaScript - Tweaking table sorter - Wrapping card number in link to patron detail page - Adding standard styles to "clear" links (see patron attributes) - Terminiology corrections (borrower-> patron, cardnumber -> card number) - Capitalization corrections - Improve display of extended attributes Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Created attachment 13531 [details] [review] Bug 8986: Followup FIX a JS error if there is no valid card number
QA Comment: Thanks Owen for this patch! I proposed a followup: if no card number is valid, a javascript error is raised. The patch hides the table and some javascript functions if the table is empty.
Created attachment 13533 [details] [review] Bug 8986: Followup FIX a JS error if there is no valid card number Signed-off-by: Owen Leonard <oleonard@myacpl.org> I can't reproduce the JS error but the template changes are correct with regard to how the page should handle errors.
This patch fixes some minors template errors in tools/modborrowers.tt Marked as Passed QA.
*** Bug 8960 has been marked as a duplicate of this bug. ***
This patch has been pushed to master.
Pushed to 3.10.x will be in 3.10.1