Idref allows to request and visit authorities in the sudoc database. In Koha, it would be possible to have a link in the opac pointing to the idref information.
Created attachment 13134 [details] [review] Bug 8992: Interfacing with the Idref webservice On the detail page (in the opac), if the biblio comes from the Sudoc, you must have a link (on the right of the author link) which open a popup with informations about this author (publications by role). To test: 1/ Modify your zebra conf in order to index the ppn: ccl.properties: Identifier-standard 1=1007 4=6 ident Identifier-standard record.abs: (biblios) melm 009 Identifier-standard:w,Number-standard:n 2/ Switch on the Idref system preference 3/ Simulate a SUDOC record: Fill a 7..$3 field with a ppn (032581270 for example). Fill the 009 field with an integer 4/ Go to the opac detail page of this notice. You should see the IDREF link. If you click on it, a popup displays a loading icon and after a few seconds (depending of the productivity of the authority :)), a list of roles. For each role, a table displays all his corresponding publications. 5/ On the right, you have 2 links: 1 for a koha search for this result and 1 for a SUDOC link
(In reply to comment #1) > Created attachment 13134 [details] [review] > Bug 8992: Interfacing with the Idref webservice > > On the detail page (in the opac), if the biblio comes from the Sudoc, > you must have a link (on the right of the author link) which open a popup > with > informations about this author (publications by role). > > To test: > > 1/ Modify your zebra conf in order to index the ppn: > ccl.properties: > Identifier-standard 1=1007 4=6 > ident Identifier-standard > > record.abs: (biblios) > melm 009 Identifier-standard:w,Number-standard:n Wouldn't it be much better to include the necessary changes in your patch?
(In reply to comment #2) > Wouldn't it be much better to include the necessary changes in your patch? Yes, of course. I will propose a new patch
Created attachment 13142 [details] [review] Bug 8992: Interfacing with the Idref webservice On the detail page (in the opac), if the biblio comes from the Sudoc, you must have a link (on the right of the author link) which open a popup with informations about this author (publications by role). To test: 1/ Switch on the Idref system preference 2/ Simulate a SUDOC record: Fill a 7..$3 field with a ppn (032581270 for example). Fill the 009 field with an integer 3/ Go to the opac detail page of this notice. You should see the IDREF link. If you click on it, a popup displays a loading icon and after a few seconds (depending of the productivity of the authority :)), a list of roles. For each role, a table displays all his corresponding publications. 4/ On the right, you have 2 links: 1 for a koha search for this result and 1 for a SUDOC link
We are currently working on this patch, please do not consider this submission for the moment
(In reply to claire.hernandez@biblibre.com from comment #5) > We are currently working on this patch, please do not consider this > submission for the moment Any updates?
Created attachment 21119 [details] [review] Bug 8992: Interfacing with the Idref webservice On the detail page (in the opac), if the biblio comes from the Sudoc, you must have a link (on the right of the author link) which open a popup with informations about this author (publications by role). To test: 1/ Switch on the Idref system preference 2/ Simulate a SUDOC record: Fill a 7..$3 field with a ppn (032581270 for example). Fill the 009 field with an integer 3/ Go to the opac detail page of this notice. You should see the IDREF link. If you click on it, a popup displays a loading icon and after a few seconds (depending of the productivity of the authority :)), a list of roles. For each role, a table displays all his corresponding publications. 4/ On the right, you have 2 links: 1 for a koha search for this result and 1 for a SUDOC link
Applying: Bug 8992: Interfacing with the Idref webservice Using index info to reconstruct a base tree... M installer/data/mysql/updatedatabase.pl Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Patch failed at 0001 Bug 8992: Interfacing with the Idref webservice The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".
Created attachment 21182 [details] [review] Bug 8992: Interfacing with the Idref webservice On the detail page (in the opac), if the biblio comes from the Sudoc, you must have a link (on the right of the author link) which open a popup with informations about this author (publications by role). To test: 1/ Switch on the Idref system preference 2/ Simulate a SUDOC record: Fill a 7..$3 field with a ppn (032581270 for example). Fill the 009 field with an integer 3/ Go to the opac detail page of this notice. You should see the IDREF link. If you click on it, a popup displays a loading icon and after a few seconds (depending of the productivity of the authority :)), a list of roles. For each role, a table displays all his corresponding publications. 4/ On the right, you have 2 links: 1 for a koha search for this result and 1 for a SUDOC link
Applying: Bug 8992: Interfacing with the Idref webservice Using index info to reconstruct a base tree... M installer/data/mysql/updatedatabase.pl M koha-tmpl/opac-tmpl/prog/en/css/opac.css M opac/opac-detail.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-detail.pl Auto-merging koha-tmpl/opac-tmpl/prog/en/css/opac.css CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/css/opac.css Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Patch failed at 0001 Bug 8992: Interfacing with the Idref webservice The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".
Created attachment 21641 [details] [review] Bug 8992: Interfacing with the Idref webservice On the detail page (in the opac), if the biblio comes from the Sudoc, you must have a link (on the right of the author link) which open a popup with informations about this author (publications by role). To test: 1/ Switch on the Idref system preference 2/ Simulate a SUDOC record: Fill a 7..$3 field with a ppn (032581270 for example). Fill the 009 field with an integer 3/ Go to the opac detail page of this notice. You should see the IDREF link. If you click on it, a popup displays a loading icon and after a few seconds (depending of the productivity of the authority :)), a list of roles. For each role, a table displays all his corresponding publications. 4/ On the right, you have 2 links: 1 for a koha search for this result and 1 for a SUDOC link
Patch applied cleanly, go forth and signoff
CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/css/opac.css
Created attachment 25358 [details] [review] Bug 8992: Interfacing with the Idref webservice On the detail page (in the opac), if the biblio comes from the Sudoc, you must have a link (on the right of the author link) which open a popup with informations about this author (publications by role). To test: 1/ Switch on the Idref system preference 2/ Simulate a SUDOC record: Fill a 7..$3 field with a ppn (032581270 for example). Fill the 009 field with an integer 3/ Go to the opac detail page of this notice. You should see the IDREF link. If you click on it, a popup displays a loading icon and after a few seconds (depending of the productivity of the authority :)), a list of roles. For each role, a table displays all his corresponding publications. 4/ On the right, you have 2 links: 1 for a koha search for this result and 1 for a SUDOC link
Created attachment 25359 [details] [review] Bug 8992: Interfacing with the Idref webservice On the detail page (in the opac), if the biblio comes from the Sudoc, you must have a link (on the right of the author link) which open a popup with informations about this author (publications by role). To test: 1/ Switch on the Idref system preference 2/ Simulate a SUDOC record: Fill a 7..$3 field with a ppn (032581270 for example). Fill the 009 field with an integer 3/ Go to the opac detail page of this notice. You should see the IDREF link. If you click on it, a popup displays a loading icon and after a few seconds (depending of the productivity of the authority :)), a list of roles. For each role, a table displays all his corresponding publications. 4/ On the right, you have 2 links: 1 for a koha search for this result and 1 for a SUDOC link Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
This seems to work, but we will need patches for the bootstrap theme
Created attachment 25365 [details] [review] Bug 8992: Interfacing with the Idref webservice - bootstrap theme This patch is the changes for the bootstrap theme at the OPAC. The test plan is the same as for the first patch.
Created attachment 25399 [details] [review] Bug 8992: Interfacing with the Idref webservice - bootstrap theme This patch is the changes for the bootstrap theme at the OPAC. The test plan is the same as for the first patch. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Just a comment to begin with: Glancing through the code, I came across a hardcoded URL in a perl script (is it really needed there), I saw css changes without less (no bootstrap?), and saw a given/when construction. Also it appears to add indexes to GRS1 and not to DOM. My impression is that we are not complete yet. Is that correct?
Created attachment 26998 [details] [review] Bug 8992: qa-followup: replace given/when with if/elsif
Created attachment 26999 [details] [review] Bug 8992: Fix index name Identifier-standard It was Identified-standard...
Created attachment 27000 [details] [review] Bug 8992: Update DOM xsl file for new indexes This file has been manually updated (very fun).
(In reply to M. de Rooy from comment #19) > I saw css changes without less (no bootstrap?), There is no change in css file for the bootstrap theme. > and saw a given/when construction. Fixed > Also it appears to add indexes to GRS1 and not to DOM. Fixed > My impression is that we are not complete yet. Is that correct? More or less, 18 months ago, the workflow for patches integration was more flexible :)
Some notes from a code review, looking at all 5 patches together: 1) opac/opac-idref.pl is missing the license information on top of the file. 2) Should this be a FIXME or even be removed? It seems the code as currently implements, is UNIMARC + Sudoc only. + else { + # unimarcCode and marc21Code 3) Patch only changes the the non-XSLT default view. Please add it to the XSLT as well or update the pref description so that this won't cause confusion. 4) Changes to the bootstrap theme doesn't seem to include the opac-detail.tt page? Maybe it got lost in rebase? 4) Why not do a more specific search using Identifier-standard? It seems the index is updated, but then never used in the new code? <a href="/cgi-bin/koha/opac-search.pl?q=kw,phr=[% doc.ppn %]" target="_blank">Koha</a></td> 5) Please add some explanatory note or link to the system preference description, so people will know what this feature is about and that it is only useful for UNIMARC SUDOC libraries. + yes: Enable + no: Disable + - the IdRef webservice from the opac detail page 6) Note: The datatables code seems duplicated in various files - should this be an include? I feel like it is in staff, but maybe not available for the OPAC yet?
7) Hm, also seems to miss sysprefs.sql.
Created attachment 27460 [details] [review] Bug 8992: Interfacing with the Idref webservice On the detail page (in the opac), if the biblio comes from the Sudoc, you must have a link (on the right of the author link) which open a popup with informations about this author (publications by role). To test: 1/ Switch on the Idref system preference 2/ Simulate a SUDOC record: Fill a 7..$3 field with a ppn (032581270 for example). Fill the 009 field with an integer 3/ Go to the opac detail page of this notice. You should see the IDREF link. If you click on it, a popup displays a loading icon and after a few seconds (depending of the productivity of the authority :)), a list of roles. For each role, a table displays all his corresponding publications. 4/ On the right, you have 2 links: 1 for a koha search for this result and 1 for a SUDOC link
Created attachment 27462 [details] [review] Bug 8992: DB changes - add the IdRef syspref
Created attachment 27463 [details] [review] Bug 8992: Add 7..$3 to the Indentifier-standard index
Created attachment 27464 [details] [review] Bug 8992: XSLT changes This patch add the same behavior as previous patches for the xslt view.
Katrin, All 7 points are taken into account in new patches. I removed the support for the prog theme too. There is just one small thing I did not manage to fix: the popup does not apply style to the table. Back to Needs Signoff.
Created attachment 29012 [details] [review] Bug 8992: Add greybox files for bootstrap
I followed the test plan. It works well. It could be nice not to display the koha links when no records are registred in our database.
Patch tested with a sandbox, by valérie bertrand <valerie.bertrand@univ-lyon3.fr>
Created attachment 29165 [details] [review] Bug 8992: Interfacing with the Idref webservice On the detail page (in the opac), if the biblio comes from the Sudoc, you must have a link (on the right of the author link) which open a popup with informations about this author (publications by role). To test: 1/ Switch on the Idref system preference 2/ Simulate a SUDOC record: Fill a 7..$3 field with a ppn (032581270 for example). Fill the 009 field with an integer 3/ Go to the opac detail page of this notice. You should see the IDREF link. If you click on it, a popup displays a loading icon and after a few seconds (depending of the productivity of the authority :)), a list of roles. For each role, a table displays all his corresponding publications. 4/ On the right, you have 2 links: 1 for a koha search for this result and 1 for a SUDOC link Signed-off-by: val
Created attachment 29166 [details] [review] Bug 8992: DB changes - add the IdRef syspref Signed-off-by: val
Created attachment 29167 [details] [review] Bug 8992: Add 7..$3 to the Indentifier-standard index Signed-off-by: val
Created attachment 29168 [details] [review] Bug 8992: XSLT changes This patch add the same behavior as previous patches for the xslt view. Signed-off-by: val
Created attachment 29169 [details] [review] Bug 8992: Add greybox files for bootstrap Signed-off-by: val
This seems to add a complete new Javascript library for a very specific UNIMARC centric feature, I am worried by that - also the version of the library seems outdated. My feeling is that we should stick with jQuery, not doing too many different things. Owen and others, could I get your opinion on this please?
Hm, is it possible the library was submitted by accident? Older versions of the patch don't seem to include it.
(In reply to Katrin Fischer from comment #39) > This seems to add a complete new Javascript library for a very specific > UNIMARC centric feature, I am worried by that - also the version of the > library seems outdated. My feeling is that we should stick with jQuery, not > doing too many different things. Owen and others, could I get your opinion > on this please? +1
(In reply to Katrin Fischer from comment #39) > My feeling is that we should stick with jQuery, not > doing too many different things. Bootstrap includes a modal dialog feature. Can this feature use that? http://getbootstrap.com/2.3.2/javascript.html#modals
Created attachment 30920 [details] [review] Bug 8992: Use the existing greybox plugin in interface/theme
(In reply to Katrin Fischer from comment #40) > Hm, is it possible the library was submitted by accident? Older versions of > the patch don't seem to include it. Sorry, I c/p the files in the interface directory and didn't remove them from the old directory. The last patch uses the existing files without moving them.
The QA script is pointing out a problem: FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt OK forbidden patterns OK tt_valid FAIL valid_template greybox.inc: not found
Created attachment 32123 [details] [review] Bug 8992: Add the greybox include file for the bootstrap theme
I am having various encoding related problems with applying this patch set. Looks like it is related to latin accented chars in the commit messages and my version of git/git bz.
(In reply to M. de Rooy from comment #47) > I am having various encoding related problems with applying this patch set. > Looks like it is related to latin accented chars in the commit messages and > my version of git/git bz. Try without the -e option.
(In reply to Jonathan Druart from comment #48) > (In reply to M. de Rooy from comment #47) > > I am having various encoding related problems with applying this patch set. > > Looks like it is related to latin accented chars in the commit messages and > > my version of git/git bz. > > Try without the -e option. Looks like replacing the é of Valérie to e is still the best option by far.. Sorry, Valerie.
Created attachment 35012 [details] [review] Bug 8992: Interfacing with the Idref webservice On the detail page (in the opac), if the biblio comes from the Sudoc, you must have a link (on the right of the author link) which open a popup with informations about this author (publications by role). To test: 1/ Switch on the Idref system preference 2/ Simulate a SUDOC record: Fill a 7..$3 field with a ppn (032581270 for example). Fill the 009 field with an integer 3/ Go to the opac detail page of this notice. You should see the IDREF link. If you click on it, a popup displays a loading icon and after a few seconds (depending of the productivity of the authority :)), a list of roles. For each role, a table displays all his corresponding publications. 4/ On the right, you have 2 links: 1 for a koha search for this result and 1 for a SUDOC link Signed-off-by: valerie bertrand <valerie.bertrand@univ-lyon3.fr>
Created attachment 35013 [details] [review] Bug 8992: DB changes - add the IdRef syspref Signed-off-by: valerie bertrand <valerie.bertrand@univ-lyon3.fr>
Created attachment 35014 [details] [review] Bug 8992: Add 7..$3 to the Indentifier-standard index Signed-off-by: valerie bertrand <valerie.bertrand@univ-lyon3.fr>
Created attachment 35015 [details] [review] Bug 8992: XSLT changes This patch add the same behavior as previous patches for the xslt view. Signed-off-by: valerie bertrand <valerie.bertrand@univ-lyon3.fr>
Created attachment 35016 [details] [review] Bug 8992: Use the existing greybox plugin in interface/theme
Created attachment 35017 [details] [review] Bug 8992: Add the greybox include file for the bootstrap theme
QA Comment: Warning: commit message does not conform to UTF-8. I replaced the é in Valérie. Some/most combinations of git/git-bz still do not like non-ASCII commit messages. I rebased the second patch for updatedatabase. No complaints from qa tools. Code looks good (remarks below). I have mainly 'dry-tested' this patch set; I did not manage to get my unimarc test db in the right condition within reasonable time. Note that opac-idref.pl can be tested more or less separately. 1st patch: css in template file (no blocker) 3rd patch: <xslo:for-each select="marc:subfield"> + <xslo:if test="contains('3', @code)"> + <z:index name="Identifier-standard:w"> + <xslo:value-of select="."/> + </z:index> + </xslo:if> + </xslo:for-each> + <xslo:for-each select="marc:subfield"> This does not look good to me. The for-each is repeated now. Same holds for 701, 702, 710, 711, 712 Note that you update biblio-zebra-indexdefs.xsl. But biblio-zebra-indexdefs.xsl should be automatically generated from a Koha index definition file with koha-indexdefs-to-zebra.xsl. Could you please add changes to biblio-koha-indexdefs and then run the xsl to create biblio-zebra-indexdefs.xsl ? Status to Failed QA for now.
Created attachment 35020 [details] [review] Bug 8992: Add 7..$3 to the Indentifier-standard index Signed-off-by: valerie bertrand <valerie.bertrand@univ-lyon3.fr>
(In reply to M. de Rooy from comment #56) > Could you please add changes to biblio-koha-indexdefs and then run the xsl > to create biblio-zebra-indexdefs.xsl ? It seems I forgot to commit the changes to the xml file. Thanks for catching that!
Will not block this patch, just want to note this: Field 009 has been superseded by new UNIMARC field 035 ?
Created attachment 35022 [details] [review] Bug 8992: Interfacing with the Idref webservice On the detail page (in the opac), if the biblio comes from the Sudoc, you must have a link (on the right of the author link) which open a popup with informations about this author (publications by role). To test: 1/ Switch on the Idref system preference 2/ Simulate a SUDOC record: Fill a 7..$3 field with a ppn (032581270 for example). Fill the 009 field with an integer 3/ Go to the opac detail page of this notice. You should see the IDREF link. If you click on it, a popup displays a loading icon and after a few seconds (depending of the productivity of the authority :)), a list of roles. For each role, a table displays all his corresponding publications. 4/ On the right, you have 2 links: 1 for a koha search for this result and 1 for a SUDOC link Signed-off-by: valerie bertrand <valerie.bertrand@univ-lyon3.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 35023 [details] [review] Bug 8992: DB changes - add the IdRef syspref Signed-off-by: valerie bertrand <valerie.bertrand@univ-lyon3.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 35024 [details] [review] Bug 8992: XSLT changes This patch add the same behavior as previous patches for the xslt view. Signed-off-by: valerie bertrand <valerie.bertrand@univ-lyon3.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 35025 [details] [review] Bug 8992: Use the existing greybox plugin in interface/theme Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 35026 [details] [review] Bug 8992: Add the greybox include file for the bootstrap theme Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 35027 [details] [review] Bug 8992: Add 7..$3 to the Indentifier-standard index Signed-off-by: valerie bertrand <valerie.bertrand@univ-lyon3.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
(In reply to M. de Rooy from comment #59) > Will not block this patch, just want to note this: > Field 009 has been superseded by new UNIMARC field 035 ? At BibLibre, we store the ppn in 009. If someone else uses this feature and wants to use another field, it will be possible to make this field configurable.
Patches pushed to master. Thanks Jonathan!
Created attachment 38639 [details] [review] Revert "Bug 8992: Use the existing greybox plugin in interface/theme" This reverts commit 986b03e1c602b057275e343e3251a5cfbcc7cca6. Tomas, due to bug 12101, this commit should be reverted.
Good catch Jonathan.
I'm documenting this now and want to ask what sudoc we're talking about. In the US Sudoc is a government document number - I assume we're talking about a French example. Is this unimarc only? If not can you attach a marc record for me to import to my test system and document this feature with? Nicole
Tomás says it's unimarc + french specific - so I'm wondering if I could have some screenshots and a bit of documentation for the manual on this one.
Checking in on this - can someone help me a bit with documentation on this? I don't have much more before I'm done with the 3.20 manual.
Nicole, IdRef is a French service for Sudoc autorities. Using the Sudoc database, it allows to request / modify / add authorities. If a record comes from the Sudoc (so 009 is filled with an integer), at the OPAC you will see "Author: Idref" if a 7..$3 (unimarc author) if filled with a ppn. On clicking on the Idref link, a popup will display. The Idref webservice is requested and all records (by roles) for this author will be displayed (see screenshot). There is 1 line / record and 2 links at the end. 1 will request Koha (cgi-bin/koha/opac-search.pl?q=ident:003381862), the other one will redirect to the sudoc page (http://www.sudoc.fr/003381862).
Created attachment 39564 [details] idref_roles
Created attachment 39565 [details] idref_detail
I just saw the images now, but here's the manual so far: http://translate.koha-community.org/manual/master/en/html-desktop/#idref will add the images in now. Nicole