Bug 9093 - 008 forgetting what material type was chosen
Summary: 008 forgetting what material type was chosen
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: David Cook
QA Contact:
URL:
Keywords:
: 11472 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-11-15 21:40 UTC by Nicole C. Engard
Modified: 2016-09-01 16:23 UTC (History)
11 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Material type as determined by Leader/06 and Leader/07 (57.28 KB, application/pdf)
2013-09-05 01:26 UTC, Bernardo Gonzalez Kriegel
Details
Bug 9093 - 008 forgetting what material type was chosen (6.02 KB, patch)
2014-06-06 04:10 UTC, David Cook
Details | Diff | Splinter Review
Bug 9093 - 008 forgetting what material type was chosen (6.41 KB, patch)
2014-06-06 04:22 UTC, David Cook
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9093 - 008 forgetting what material type was chosen (6.56 KB, patch)
2014-06-06 13:31 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 9093 - followup to fix tab (1.20 KB, patch)
2014-06-06 13:33 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 9093 - 008 forgetting what material type was chosen (6.62 KB, patch)
2014-06-06 18:02 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2012-11-15 21:40:22 UTC
See the video for clarification (http://screencast.com/t/Rtrx2QZk).  When you use the 008 plugin you choose your material type - so if you choose VM for example you then have visual material fields.  You then fill in your 008 and save.  This all saves fine and shows right in NORMAL view.  But if I click the 008 plugin again it says BK again .. even though it was VM that I made changes to. The plugin should remember the material type properly.

This happens in master and 3.8.5

Nicole
Comment 1 Claudio Costales 2013-08-18 23:38:49 UTC
This happens in 3.12.3 too. Issue very claimed by staff users.
Comment 2 Pablo López Liotti 2013-09-02 22:59:00 UTC
This issue was reported today to me by my library staff.
If the procedure of change field 008 values is repeated sometimes, finally it´s possible save the record with correct values.

There is any patch o tip to prevent this?

We are using 3.12.00
Comment 3 Bernardo Gonzalez Kriegel 2013-09-05 01:26:57 UTC
Created attachment 20789 [details]
Material type as determined by Leader/06 and Leader/07

008 do not forgets, because it don't know.
As stated in http://www.loc.gov/marc/formatintegration.html,
"Field 008 does not carry any explicit flag identifying the definition of positions 18-34. Instead, the identification of the type of field 008 is dependent on the content of Leader/06 (Type of record) and,in the case of textual material (i.e., when Leader/06 contains value a), the content of Leader/07 (Bibliographic level)."

So to fix this we need a way to pass Leader/06 and /07 to the plugin so it learns and shows proper material type, and that if the leader is correctly filled.

Attached is a PDF with all possible combinations on leader/06 /07 and what kind of material type must be set.
Comment 4 David Cook 2014-06-05 23:48:12 UTC
*** Bug 11472 has been marked as a duplicate of this bug. ***
Comment 5 David Cook 2014-06-05 23:49:37 UTC
(In reply to Bernardo Gonzalez Kriegel from comment #3)
> Created attachment 20789 [details]
> Material type as determined by Leader/06 and Leader/07
> 
> 008 do not forgets, because it don't know.
> As stated in http://www.loc.gov/marc/formatintegration.html,
> "Field 008 does not carry any explicit flag identifying the definition of
> positions 18-34. Instead, the identification of the type of field 008 is
> dependent on the content of Leader/06 (Type of record) and,in the case of
> textual material (i.e., when Leader/06 contains value a), the content of
> Leader/07 (Bibliographic level)."
> 
> So to fix this we need a way to pass Leader/06 and /07 to the plugin so it
> learns and shows proper material type, and that if the leader is correctly
> filled.
> 
> Attached is a PDF with all possible combinations on leader/06 /07 and what
> kind of material type must be set.

Good work on the PDF! It looks like it's incorrect for 06 "a" 07 "i", but otherwise perfect.

Field 008/18-34 Configuration
If Leader/06 = a and Leader/07 = a, c, d, or m: Books
If Leader/06 = a and Leader/07 = b, i, or s: Continuing Resources
If Leader/06 = t: Books
If Leader/06 = c, d, i, or j: Music
If Leader/06 = e, or f: Maps
If Leader/06 = g, k, o, or r: Visual Materials
If Leader/06 = m: Computer Files
If Leader/06 = p: Mixed Materials
http://www.loc.gov/marc/bibliographic/bdleader.html

I'm going to look at this one today.
Comment 6 David Cook 2014-06-06 04:10:05 UTC Comment hidden (obsolete)
Comment 7 David Cook 2014-06-06 04:22:13 UTC Comment hidden (obsolete)
Comment 8 Bernardo Gonzalez Kriegel 2014-06-06 13:31:48 UTC Comment hidden (obsolete)
Comment 9 Bernardo Gonzalez Kriegel 2014-06-06 13:33:09 UTC Comment hidden (obsolete)
Comment 10 Kyle M Hall 2014-06-06 18:02:00 UTC
Created attachment 28714 [details] [review]
[PASSED QA] Bug 9093 - 008 forgetting what material type was chosen

This patch adds material type checking to the MARC21 008 tag editor,
based on value from the leader. That is, the 008 tag editor
will choose an initial material type based on the leader 06
(and if necessary the leader 07 position)

_TEST PLAN_
1) Create a new record or open an existing bib record
2) Change position 6 from its current value (probably "a") to
"c" or "e" or "g" or "m" or "p". (See the end of this message
for a comprehensive list of 06 values to try.)
3) Open the 008 tag editor
4) Note that it still says BKS even though it should say "MU"
or "MP" or "VM" or "CF" or "MX".

5) Apply the patch

6) Repeat steps 2 and 3.
7) Note that the 008 tag editor now shows the correct material
type based on the leader.

8) For more comprehensive checking, try switching position 6
back to "a" and changing position 7 to "b" instead of "m".
9) Note that it will switch from "BKS" to "CR".
10) Fin

Comprehensive mapping:

Field 008/18-34 Configuration
If Leader/06 = a and Leader/07 = a, c, d, or m: Books
If Leader/06 = a and Leader/07 = b, i, or s: Continuing Resources
If Leader/06 = t: Books
If Leader/06 = c, d, i, or j: Music
If Leader/06 = e, or f: Maps
If Leader/06 = g, k, o, or r: Visual Materials
If Leader/06 = m: Computer Files
If Leader/06 = p: Mixed Materials
http://www.loc.gov/marc/bibliographic/bdleader.html

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work as described, nice job.
koha-qa complains for a tab char, removed on followup.
Mode change on TT file (+x), removed.
No other errors

NOTE: It would be desirable to update LEADER values
to reflect changes on 008.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 11 Tomás Cohen Arazi 2014-06-21 13:54:51 UTC
Patch pushed to master.

Thanks David!
Comment 12 Galen Charlton 2014-06-25 22:40:35 UTC
Pushed to 3.16.x for inclusion in 3.16.1.
Comment 13 David Cook 2014-07-03 02:52:45 UTC
(In reply to Kyle M Hall from comment #10)

> NOTE: It would be desirable to update LEADER values
> to reflect changes on 008.
> 

Unfortunately, I don't think that's possible, since it's a one way mapping. You can arrive at the same material type via multiple different Leader value combinations, so you can't reverse engineer a material type to get the Leader values.