Created attachment 14405 [details] [review] Bug 9346 - acqui/neworderempty.pl ignores exchange rates and destroys user data on page load This restores behaviour of new order form before Bug 5335 merge Test scenario: 1. load Receipt summary for existing customer 2. take note of Unit cost and Order cost 3. open existing order line and verify that Replacement cost, Budgeted cost and Total are not re-calculated on page load 4. change currency and verify that costs are updated (change currency to system default and all values should become same as vendor price) 5. change Quantity, get alert "You can't add a new item, please create a new order line" and verify that Total still reflects correct value
Created attachment 14410 [details] [review] Bug 9346 - acqui/neworderempty.pl ignores exchange rates and destroys user data on page load This restores behaviour of new order form before Bug 5335 merge Test scenario: 1. load Receipt summary for existing customer 2. take note of Unit cost and Order cost 3. open existing order line and verify that Replacement cost, Budgeted cost and Total are not re-calculated on page load 4. change currency and verify that costs are updated (change currency to system default and all values should become same as vendor price) 5. change Quantity, get alert "You can't add a new item, please create a new order line" and verify that Total still reflects correct value Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 14425 [details] [review] Bug 9346 - acqui/neworderempty.pl ignores exchange rates and destroys user data on page load This restores behaviour of new order form before Bug 5335 merge Test scenario: 1. load Receipt summary for existing customer 2. take note of Unit cost and Order cost 3. open existing order line and verify that Replacement cost, Budgeted cost and Total are not re-calculated on page load 4. change currency and verify that costs are updated (change currency to system default and all values should become same as vendor price) 5. change Quantity, get alert "You can't add a new item, please create a new order line" and verify that Total still reflects correct value Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Elliott Davis <elliott@bywatersolions.com>
I do not think this patch works. Replacement cost, Budgeted cost, and Total are always zero in neworderempty, no matter what I set them to when saving. Moreover, changing the currency does not seem to do anything at all. Is there a particular syspref I need to have set in a certain way?
Never mind. The problem was bug 9339. It turns out that it was resetting my language to en-GB every time I moved between pages.
This patch has been pushed to master.
Pushed to 3.10.x