Right now the number of results per page for reports is fixed at 20. It would be nice to allow for more results per page, while retaining the default as 20 per page.
Created attachment 14671 [details] [review] Bug 9417 - Allow number of results per page to be selectable for guided reports This patch adds the ability to select the number of row to show per page while retaining the default rows per page as 20. Test Plan: 1) Apply patch 2) Run a guided report that will have many resultant rows 3) Try the various rows per page options 4) Verify the rows per page selected is retained when paging through results
Created attachment 15083 [details] screenshot of incorrectly constructed select list The feature works as advertised, but the drop-down for selecting the number of rows to display isn't being constructed correctly. As you can see in the screenshot I've attached, if you change the number of rows and re-run the report, the currently selected number of rows is duplicated at the top of the option list. Idiomatic HTML would wouldn't duplicate the value but would simply select the corresponding entry on the option list.
Created attachment 15090 [details] [review] Bug 9417 - Allow number of results per page to be selectable for guided reports This patch adds the ability to select the number of row to show per page while retaining the default rows per page as 20. Test Plan: 1) Apply patch 2) Run a guided report that will have many resultant rows 3) Try the various rows per page options 4) Verify the rows per page selected is retained when paging through results
Fixed!
Created attachment 15148 [details] [review] [SIGNED-OFF] Bug 9417 - Allow number of results per page to be selectable for guided reports This patch adds the ability to select the number of row to show per page while retaining the default rows per page as 20. Test Plan: 1) Apply patch 2) Run a guided report that will have many resultant rows 3) Try the various rows per page options 4) Verify the rows per page selected is retained when paging through results Signed-off-by: Owen Leonard <oleonard@myacpl.org>
QA comment: Very useful patch! It adds a drop-down list with the number of displayed lines. Perhaps we would like to have a "all" entry, but browsers won't like this idea :) Code clean, few code. Marked as Passed QA.
Created attachment 15155 [details] [review] Bug 9417 - Allow number of results per page to be selectable for guided reports This patch adds the ability to select the number of row to show per page while retaining the default rows per page as 20. Test Plan: 1) Apply patch 2) Run a guided report that will have many resultant rows 3) Try the various rows per page options 4) Verify the rows per page selected is retained when paging through results Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch has been pushed to master.