Bug 9719 - Changing the rows per page on a custom report fails if it has user supplied parameters
Summary: Changing the rows per page on a custom report fails if it has user supplied p...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact:
URL:
Keywords:
: 9994 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-02-27 13:46 UTC by Kyle M Hall
Modified: 2013-12-05 20:09 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9719 - Changing the rows per page on a custom report fails if it has user supplied parameters (2.53 KB, patch)
2013-02-27 13:51 UTC, Kyle M Hall
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9719 - Changing the rows per page on a custom report fails if it has user supplied parameters (2.63 KB, patch)
2013-04-30 18:25 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 9719 - Changing the rows per page on a custom report fails if it has user supplied parameters (2.69 KB, patch)
2013-05-01 06:40 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2013-02-27 13:46:40 UTC
If you create an SQL report that includes one or more parameters, using the 'rows per page' pulldown does not work. Instead, it will prompt for the parameters again and shows the first page of output.
Comment 1 Kyle M Hall 2013-02-27 13:51:00 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-04-30 18:25:35 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-05-01 06:40:45 UTC
Created attachment 17865 [details] [review]
[PASSED QA] Bug 9719 - Changing the rows per page on a custom report fails if it has user supplied parameters

If you create an SQL report that includes one or more parameters,
using the 'rows per page' pulldown does not work. Instead, it will
prompt for the parameters again and shows the first page of output.

Test Plan:
1) Create a new report from sql as follows:
    SELECT * FROM borrowers WHERE surname LIKE <<Last Name>> AND firstname LIKE <<First Name>>
2) Run this report
3) Change the 'Rows per page' and click 'Update'
4) This should kick you back to the start where the report asks you for your parameters
5) Apply the patch
6) Repeat step 3, this time is should work correctly

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely now. All tests and QA script pass.
Comment 4 Jared Camins-Esakov 2013-05-01 11:27:59 UTC
This patch has been pushed to master and 3.12.x.
Comment 5 Chris Cormack 2013-05-09 07:03:19 UTC
Does not apply to 3.10.x please rebase if needed
Comment 6 Katrin Fischer 2013-05-11 13:11:54 UTC
*** Bug 9994 has been marked as a duplicate of this bug. ***
Comment 7 Fridolin Somers 2013-05-17 09:53:07 UTC
(In reply to comment #5)
> Does not apply to 3.10.x please rebase if needed

This bug corrects an enhancement added by bug 9417 which has only been pushed on master.
So no need to create a 3.10.x rebase.

@Kyle : nice job, you're like a bug hunter.