When editing a subscription under Plack, the area for entering manual history appears regardless of whether you enabled manual history or not. I also get the following warnings in the log, one of which, presumably, is related to the problem: Use of uninitialized value $firstissuedate in string eq at /home/jcamins/kohaclone/serials/subscription-add.pl line 92. Use of uninitialized value $firstissuedate in substr at /home/jcamins/kohaclone/serials/subscription-add.pl line 105. Use of qw(...) as parentheses is deprecated at /home/jcamins/kohaclone/serials/subscription-add.pl line 95. Subroutine letter_loop redefined at /home/jcamins/kohaclone/serials/subscription-add.pl line 180. Subroutine _get_sub_length redefined at /home/jcamins/kohaclone/serials/subscription-add.pl line 195. Subroutine redirect_add_subscription redefined at /home/jcamins/kohaclone/serials/subscription-add.pl line 205. Variable "$firstissuedate" is not available at /home/jcamins/kohaclone/serials/subscription-add.pl line 338. Subroutine redirect_mod_subscription redefined at /home/jcamins/kohaclone/serials/subscription-add.pl line 274.
Actually, the area for entering manual history always shows up, regardless whether you're running under Plack or not.
Created attachment 15209 [details] [review] Bug 9574: Plack fixes for serials/subscription-add.pl This patch fixes the following warnings under Plack: * Use of uninitialized value $firstissuedate in string eq at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 92. * Use of uninitialized value $firstissuedate in substr at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 105. * Use of qw(...) as parentheses is deprecated at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 95. * Variable "$firstissuedate" is not available at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 338. To test: 1) Create a subscription. Ensure that setting the first issue's publication date works. 2) Edit a subscription. Ensure that the first issue's publication date shows up. 3) Sign off.
The manual history block showing up was already reported as bug 7608.
Created attachment 15314 [details] [review] Bug 9574: Plack fixes for serials/subscription-add.pl This patch fixes the following warnings under Plack: * Use of uninitialized value $firstissuedate in string eq at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 92. * Use of uninitialized value $firstissuedate in substr at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 105. * Use of qw(...) as parentheses is deprecated at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 95. * Variable "$firstissuedate" is not available at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 338. To test: 1) Create a subscription. Ensure that setting the first issue's publication date works. 2) Edit a subscription. Ensure that the first issue's publication date shows up. 3) Sign off. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 15876 [details] [review] [PASSED QA] Bug 9574: Plack fixes for serials/subscription-add.pl This patch fixes the following warnings under Plack: * Use of uninitialized value $firstissuedate in string eq at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 92. * Use of uninitialized value $firstissuedate in substr at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 105. * Use of qw(...) as parentheses is deprecated at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 95. * Variable "$firstissuedate" is not available at \ /home/jcamins/kohaclone/serials/subscription-add.pl line 338. To test: 1) Create a subscription. Ensure that setting the first issue's publication date works. 2) Edit a subscription. Ensure that the first issue's publication date shows up. 3) Sign off. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> No regressions found, all tests and QA script pass.
This patch has been pushed to master.
Pushed to 3.10.x will be in 3.10.4