Currently, the layout for the Edit/Add Layout screen of the Patron Card Creator is in complete disarray, when viewed in Internet Explorer (of any version). The nav bar is pushed to the bottom of the page, every fieldset is empty (as their contents have been pushed out into different parents of the page), and the checkboxes don't work. The cause appears to be some extraneous mark-up (a few extra fieldset and li elements)and some missing mark-up (ol elements to wrap the list elements, especially when nesting lists within each other and within div elements).
Created attachment 15287 [details] [review] Bug 9603 - Fix layout of Patron Card Creator Layout screen for display in IE This patch removes empty and extraneous fieldset and li elements. It also adds ol elements to all of the nested li elements, which were creating layout problems in IE, especially when they were interwoven with div elements. IE had problems opening and closing tags, which created some major chaos. This patch also adds stylistic spacing/nesting to the HTML, so that it is easier to visually separate elements when debugging. 99.9% of the mods in this patch are actually just whitespace alterations. --- Test Plan: Before applying the patch: 1) Open Koha using any version of Internet Explorer 2) Go to the Patron Card Creator in the Tools module 3) Go to Manage Layouts 4) Add or Edit a layout 5) Note that all the elements on the page are presented in haphazard fashion with the navbar pushed to the bottom of the page. Apply the patch. 6) Refresh the page 7) Note that the elements are now laid out on the page in the same way that they would appear in a modern browser like Firefox or Chrome (look at the same page in one of those browsers to confirm).
Created attachment 15305 [details] [review] [SIGNED-OFF] Bug 9603 - Fix layout of Patron Card Creator Layout screen for display in IE Currently, the layout for the Edit/Add Layout screen of the Patron Card Creator is in complete disarray, when viewed in Internet Explorer (of any version). This patch removes empty and extraneous fieldset and li elements. It also adds ol elements to all of the nested li elements, which were creating layout problems in IE, especially when they were interwoven with div elements. IE had problems opening and closing tags, which created some major chaos. This patch also adds stylistic spacing/nesting to the HTML, so that it is easier to visually separate elements when debugging. 99.9% of the mods in this patch are actually just whitespace alterations. Test Plan: Before applying the patch: 1) Open Koha using any version of Internet Explorer 2) Go to the Patron Card Creator in the Tools module 3) Go to Manage Layouts 4) Add or Edit a layout 5) Note that all the elements on the page are presented in haphazard fashion with the navbar pushed to the bottom of the page. Apply the patch. 6) Refresh the page 7) Note that the elements are now laid out on the page in the same way that they would appear in a modern browser like Firefox or Chrome (look at the same page in one of those browsers to confirm). Signed-off-by: Owen Leonard <oleonard@myacpl.org> I don't like all the whitespace changes in this patch. Making whitespace changes as well as code/markup changes is generally speaking a violation of coding guidelines. However, this is not a frequently-modified template and a diff which ignores whitespace changes shows that the real changes are minor and effective. I'm signing off and correcting the commit message to include a description of the fix and the test plan.
(In reply to comment #2) > I don't like all the whitespace changes in this patch. Making whitespace > changes as well as code/markup changes is generally speaking a violation > of coding guidelines. However, this is not a frequently-modified > template and a diff which ignores whitespace changes shows that the real > changes are minor and effective. > > I'm signing off and correcting the commit message to include a > description of the fix and the test plan. Do not like these whitespace changes too. Could the author resolve this please and make life easier for QA? Thanks!
(In reply to M. de Rooy from comment #3) > (In reply to comment #2) > > I don't like all the whitespace changes in this patch. Making whitespace > > changes as well as code/markup changes is generally speaking a violation > > of coding guidelines. However, this is not a frequently-modified > > template and a diff which ignores whitespace changes shows that the real > > changes are minor and effective. > > > > I'm signing off and correcting the commit message to include a > > description of the fix and the test plan. > > Do not like these whitespace changes too. Could the author resolve this > please and make life easier for QA? Thanks! If you use the -w flag to not show whitespace changes, you should be all right. However, I'm working on this patch again locally today, so I'll look at uploading a new version with code changes in one patch and whitespace changes in the other.
Created attachment 20519 [details] [review] Bug 9603 - Fix layout of Patron Card Creator Layout screen for display in IE Currently, the layout for the Edit/Add Layout screen of the Patron Card Creator is in complete disarray, when viewed in Internet Explorer (of any version). The nav bar is pushed to the bottom of the page, every fieldset is empty (as their contents have been pushed out into different parts of the page), and the checkboxes don't work. The cause appears to be some extraneous mark-up (a few extra fieldset and li elements)and some missing mark-up (ol elements to wrap the list elements, especially when nesting lists within each other and within div elements). --- This patch removes empty and extraneous fieldset and li elements. It also adds ol elements to all of the nested li elements, which were creating layout problems in IE, especially when they were interwoven with div elements. IE had problems opening and closing tags, which created some major chaos. --- Test Plan: Before applying the patch: 1) Open Koha using any version of Internet Explorer 2) Go to the Patron Card Creator in the Tools module 3) Go to Manage Layouts 4) Add or Edit a layout 5) Note that all the elements on the page are presented in haphazard fashion with the navbar pushed to the bottom of the page. Apply the patch. 6) Refresh the page 7) Note that the elements are now laid out on the page in the same way that they would appear in a modern browser like Firefox or Chrome (look at the same page in one of those browsers to confirm). (N.B. The exception is IE7. While the layout has been improved, it is now displayed linearly (i.e. without the YUI grid system). I've opened up Bug 10772 to start discussing this problem.)
Actually, I'm not sure that it's necessary to add a patch for the whitespace. I will if folks think it's a good idea, but this is the essence of the patch. P.S. It looks like I forgot to include Owen's sign off in this latest patch. Could QA folks add that back in if necessary?
Created attachment 20627 [details] [review] [SIGNED-OFF] Bug 9603 - Fix layout of Patron Card Creator Layout screen for display in IE Currently, the layout for the Edit/Add Layout screen of the Patron Card Creator is in complete disarray, when viewed in Internet Explorer (of any version). The nav bar is pushed to the bottom of the page, every fieldset is empty (as their contents have been pushed out into different parts of the page), and the checkboxes don't work. The cause appears to be some extraneous mark-up (a few extra fieldset and li elements)and some missing mark-up (ol elements to wrap the list elements, especially when nesting lists within each other and within div elements). Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 20672 [details] [review] [PASSED QA] Bug 9603 - Fix layout of Patron Card Creator Layout screen for display in IE Currently, the layout for the Edit/Add Layout screen of the Patron Card Creator is in complete disarray, when viewed in Internet Explorer (of any version). The nav bar is pushed to the bottom of the page, every fieldset is empty (as their contents have been pushed out into different parts of the page), and the checkboxes don't work. The cause appears to be some extraneous mark-up (a few extra fieldset and li elements)and some missing mark-up (ol elements to wrap the list elements, especially when nesting lists within each other and within div elements). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I didn't test this in IE, but changes are fixing general problems with HTML validity. Checking the page with the W3C validator: Before: 27 Errors, 7 warning(s) After: 6 Errors, 7 warning(s) All tests and QA script pass, page looks alright. Would be nice to see the remaining problems fixed in a follow-up.
Pushed to master -- thanks, David!
This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks David!
Pushed to 3.10.x, will be in 3.10.12