Bug 9621 - Replace YUI menu on lists pages with Bootstrap
Summary: Replace YUI menu on lists pages with Bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL: /cgi-bin/koha/virtualshelves/shelves.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-15 15:49 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9420 - Work on Bootstrap for Koha: Lists toolbar (8.40 KB, patch)
2013-02-15 16:07 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9621 - Replace YUI menu on lists pages with Bootstrap (8.39 KB, patch)
2013-02-15 16:14 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9621 - Replace YUI menu on lists pages with Bootstrap (8.54 KB, patch)
2013-02-15 16:29 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 9621 - Replace YUI menu on lists pages with Bootstrap (8.63 KB, patch)
2013-02-17 09:35 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-02-15 15:49:11 UTC
The toolbar include file used by staff client lists pages uses YUI to generate buttons and menus. It should use Bootstrap instead.
Comment 1 Owen Leonard 2013-02-15 16:07:01 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-02-15 16:14:08 UTC Comment hidden (obsolete)
Comment 3 Bernardo Gonzalez Kriegel 2013-02-15 16:29:56 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2013-02-17 09:35:15 UTC
Created attachment 15447 [details] [review]
[PASSED QA] Bug 9621 - Replace YUI menu on lists pages with Bootstrap

This patch converts the toolbar include file used by lists pages to
Bootstrap, replacing YUI button and menu code with Bootstrap markup.

To test, view any page in virtualshelves/ which uses
virtualshelves-toolbar.inc (shelves.pl). Buttons and menus should look
correct and work correctly when viewing own lists, others' lists, etc.

Revised: corrected bug number and title
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Work as described. No error. Looks very good.
As well as Bug 9616 the result is 10px downward from the original.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, on problems found.
Comment 5 Jared Camins-Esakov 2013-02-18 13:04:24 UTC
This patch has been pushed to master.