Bug 9645 - Replace YUI buttons on the quotes management page with Bootstrap
Summary: Replace YUI buttons on the quotes management page with Bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL: /cgi-bin/koha/tools/quotes.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-15 20:39 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9645 - Replace YUI buttons on the quotes management page with Bootstrap (6.54 KB, patch)
2013-02-15 20:44 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9645 - Replace YUI buttons on the quotes management page with Bootstrap (6.86 KB, patch)
2013-02-15 21:43 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 9645 - Replace YUI buttons on the quotes management page with Bootstrap (7.24 KB, patch)
2013-02-17 15:01 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-02-15 20:39:21 UTC
The toolbar buttons on the quotes management page are generated by YUI. They should use Bootstrap instead.
Comment 1 Owen Leonard 2013-02-15 20:44:58 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-02-15 21:43:57 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-02-17 15:01:10 UTC
Created attachment 15472 [details] [review]
[PASSED QA] Bug 9645 - Replace YUI buttons on the quotes management page with Bootstrap

This patch converts the toolbar include file used by the quotes editor
to Bootstrap, replacing YUI button and menu code with Bootstrap markup.

To test, view any page in the quotes editor. Buttons and menus should
look correct and work correctly. Test save, delete, and upload buttons
on the summary page, and save and delete buttons on the upload page.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: All buttons work. Tested add, delete and upload.
You are using icon-remove and not icon-remove-circle,
which I prefer but is different of Bug 9627.
Question: "Import quotes" takes you to "Quotes uploader",
would not it be more consistent to use "Upload quotes" or
"Quotes importer"?

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, no problems found.
I think the difference to 9627 is, that this really deletes
quotes, while the icon-remove-circle is used for closing subscriptions.
Closed subscriptions remain in the system, it's just a way to indicate
that there will be no new issues. There is a separate option to really
delete subscriptions.
Comment 4 Jared Camins-Esakov 2013-02-18 14:10:06 UTC
This patch has been pushed to master.