In the list of all the open/closed basketgroups for a vendor, you just have the name of each basketgroup, and 3 action buttons. For libraries using basketgroup, it would be very usefull to see more information, all the more since librarians cannot see the content of a basketgroup without reopening it (this point could be fixed in an other bug...) To begin, I propose to add the following columns : - basketgroupnumber - billingplace - deliveryplace - number of baskets in each basketgroup and maybe later : - date of creation - date of closure - the list of baskets included in the basketgroup - number of orders - number received/non received orders M. Saby
Created attachment 16173 [details] [review] [PATCH] Bug 9806 : Add new columns to basket groups lists In the list of all the open/closed basketgroups for a vendor, you just have the name of each basketgroup, and 3 action buttons. It is not sufficient for libraries using basketgroup. Warning : this patch must be tested with BZ 9771 applied. If BZ 9771 is not pushed to master when you test, apply it before. This patch adds the following columns : - number (id of basketgroup) - billingplace (name of the library) - deliveryplace (name of the library, or "free delivery place") - number of baskets in each basketgroup To test : 1) make some basketgroups with 0, 1, 2 baskets 2) make some basketgroups with different billing and deliveryplace 3) check the list of open and closed basketgroups 4) check action buttons are working like before M. Saby Rennes 2 university
Tried on a sandbox : Applying: Bug 9806 : Add new columns to basket groups lists Repository lacks necessary blobs to fall back on 3-way merge.
zut! I will rebase it tomorrow. M. Saby
you need to apply BZ 9771 first. I suppose you cannot in a sandbox ;-) M. Saby
(In reply to comment #3) > zut! > I will rebase it tomorrow. > M. Saby There are several whitespace changes in your patch. You should split your patch into feature and cosmetic changes.
Created attachment 16307 [details] [review] PATCH 1/2][Revised] Bug 9806 : Add new columns to basket groups lists Revised to fix whitespace problems. Cosmetic changes put in an other patch. In the list of all the open/closed basketgroups for a vendor, you just have the name of each basketgroup, and 3 action buttons. It is not sufficient for libraries using basketgroup. Warning : this patch must be tested with BZ 9771 applied. If BZ 9771 is not pushed to master when you test, apply it before. This patch adds the following columns : - number (id of basketgroup) - billingplace (name of the library) - deliveryplace (name of the library, or "free delivery place") - number of baskets in each basketgroup To test : 1) make some basketgroups with 0, 1, 2 baskets 2) make some basketgroups with different billing and deliveryplace 3) check the list of open and closed basketgroups 4) check action buttons are working like before M. Saby
Created attachment 16309 [details] [review] [PATCH 2/2] cosmetic patch (reindent part of basketgroup.tt) Only reindenting the end of basketgroup.tt M. Saby
Still to apply on the top of 9771. M. Saby
Comment on attachment 16309 [details] [review] [PATCH 2/2] cosmetic patch (reindent part of basketgroup.tt) Cosmetic patch is useless M. saby
Created attachment 16509 [details] [review] [SIGNED-OFF] Bug 9806 : Add new columns to basket groups lists Revised to fix whitespace problems. Cosmetic changes put in an other patch. In the list of all the open/closed basketgroups for a vendor, you just have the name of each basketgroup, and 3 action buttons. It is not sufficient for libraries using basketgroup. Warning : this patch must be tested with BZ 9771 applied. If BZ 9771 is not pushed to master when you test, apply it before. This patch adds the following columns : - number (id of basketgroup) - billingplace (name of the library) - deliveryplace (name of the library, or "free delivery place") - number of baskets in each basketgroup To test : 1) make some basketgroups with 0, 1, 2 baskets 2) make some basketgroups with different billing and deliveryplace 3) check the list of open and closed basketgroups 4) check action buttons are working like before Signed-off-by: Owen Leonard <oleonard@myacpl.org> This is a nice improvement!
Note : bz9771 has been pushed to master some minutes ago. M. Saby
Why not using Koha::Template::Plugin::KohaBranchName to change branch code into branch description into template instead of into perl page ?
I did not know it was possible ;-) If you think it is a better solution I will rewrite my patch. Mathieu
I think it would be great. Have a look at Bug 9229 patch to see how to do it.
I agree with the Fridolyn's proposal. Marked as Failed QA.
I had forgotten this bug... Will take a look later and rewrite it. Mathieu
Created attachment 18228 [details] [review] [PATCH 2] Bug 9806 : QA Followup - use template plugin for branch names With this followup, instead of passing the real names of the branches to template file, only the branchcodes are passed. The branchcodes are translated into branchnames in template file, using the KohaBranchName template plugin. To test : do the same test as for main patch : 1) make some basketgroups with 0, 1, 2 baskets 2) make some basketgroups with different billing and deliveryplace 3) check the list of open and closed basketgroups 4) check action buttons are working like before M. Saby
Test on sandbox : Sandbox setup by tredok.pierre@gmail.com with database 2 and bug 9806 on Thu May 23 08:44:09 2013 Something went wrong ! Applying: Bug 9806 : Add new columns to basket groups lists Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt Applying: Bug 9806 : QA Followup - use template plugin for branch names Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9806 : QA Followup - use template plugin for branch names When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 9806 - Show more information on basketgroups lists [SIGNED-OFF] Bug 9806 : Add new columns to basket groups lists Apply? [yn] [PATCH 2] Bug 9806 : QA Followup - use template plugin for branch names Apply? [yn] Patch left in /tmp/PATCH-2-Bug-9806--QA-Followup---use-template-plugi-GS6lZO.patch
The patches apply correctly on a local instance. Switch back to Needs SO.
Thank you Jonathan. I could not check this morning, I am struggling with my VM... Mathieu
Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com>
Created attachment 18331 [details] [review] Bug 9806 : QA Followup - use template plugin for branch names With this followup, instead of passing the real names of the branches to template file, only the branchcodes are passed. The branchcodes are translated into branchnames in template file, using the KohaBranchName template plugin. To test : do the same test as for main patch : 1) make some basketgroups with 0, 1, 2 baskets 2) make some basketgroups with different billing and deliveryplace 3) check the list of open and closed basketgroups 4) check action buttons are working like before Signed-off-by: Pierre Angot <tredok.pierre@gmail.com>
So, it is working? Your sandbox was not rightly set-up ? Mathieu
QA comment: Ergonomic improvement for the basket group table. Simple patch, just add some columns on the table. Marked as Passed QA.
Created attachment 18333 [details] [review] Bug 9806 : Add new columns to basket groups lists Revised to fix whitespace problems. Cosmetic changes put in an other patch. In the list of all the open/closed basketgroups for a vendor, you just have the name of each basketgroup, and 3 action buttons. It is not sufficient for libraries using basketgroup. Warning : this patch must be tested with BZ 9771 applied. If BZ 9771 is not pushed to master when you test, apply it before. This patch adds the following columns : - number (id of basketgroup) - billingplace (name of the library) - deliveryplace (name of the library, or "free delivery place") - number of baskets in each basketgroup To test : 1) make some basketgroups with 0, 1, 2 baskets 2) make some basketgroups with different billing and deliveryplace 3) check the list of open and closed basketgroups 4) check action buttons are working like before Signed-off-by: Owen Leonard <oleonard@myacpl.org> This is a nice improvement! Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 18334 [details] [review] Bug 9806 : QA Followup - use template plugin for branch names With this followup, instead of passing the real names of the branches to template file, only the branchcodes are passed. The branchcodes are translated into branchnames in template file, using the KohaBranchName template plugin. To test : do the same test as for main patch : 1) make some basketgroups with 0, 1, 2 baskets 2) make some basketgroups with different billing and deliveryplace 3) check the list of open and closed basketgroups 4) check action buttons are working like before Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 18335 [details] [review] Bug 9806: Remove single pixel on the basketgroup table Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
The last patch fixes a small issue with the Datatable sDom.
Jonathan, that's not my patch...
(In reply to comment #29) > Jonathan, that's not my patch... Hum... 2 first patchs is yours. Last one is mine. It is a QA followup. Do you disagree with it?
If it is a QA patch, that's ok! In fact I did not look... I just look the title, and it reminds me an other bug, so I thought it as an attachement error. Mathieu
(it reminds me BZ 10287)
Pushed to master. Thanks, Mathieu!