Bug 9806 - Show more information on basketgroups lists
Summary: Show more information on basketgroups lists
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Mathieu Saby
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on: 9771
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-13 13:01 UTC by Mathieu Saby
Modified: 2014-12-07 20:02 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
[PATCH] Bug 9806 : Add new columns to basket groups lists (15.77 KB, patch)
2013-03-15 22:08 UTC, Mathieu Saby
Details | Diff | Splinter Review
PATCH 1/2][Revised] Bug 9806 : Add new columns to basket groups lists (6.30 KB, patch)
2013-03-18 19:51 UTC, Mathieu Saby
Details | Diff | Splinter Review
[PATCH 2/2] cosmetic patch (reindent part of basketgroup.tt) (10.39 KB, patch)
2013-03-18 19:52 UTC, Mathieu Saby
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9806 : Add new columns to basket groups lists (6.42 KB, patch)
2013-03-20 12:44 UTC, Owen Leonard
Details | Diff | Splinter Review
[PATCH 2] Bug 9806 : QA Followup - use template plugin for branch names (4.47 KB, patch)
2013-05-18 13:35 UTC, Mathieu Saby
Details | Diff | Splinter Review
Bug 9806 : QA Followup - use template plugin for branch names (4.52 KB, patch)
2013-05-23 08:28 UTC, Paul Poulain
Details | Diff | Splinter Review
Bug 9806 : Add new columns to basket groups lists (6.46 KB, patch)
2013-05-23 08:57 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 9806 : QA Followup - use template plugin for branch names (4.55 KB, patch)
2013-05-23 08:57 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 9806: Remove single pixel on the basketgroup table (1.39 KB, patch)
2013-05-23 08:57 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Saby 2013-03-13 13:01:21 UTC
In the list of all the open/closed basketgroups for a vendor, you just have the name of each basketgroup, and 3 action buttons.
For libraries using basketgroup, it would be very usefull to see more information, all the more since librarians cannot see the content of a basketgroup without reopening it (this point could be fixed in an other bug...)

To begin, I propose to add the following columns :
- basketgroupnumber
- billingplace
- deliveryplace
- number of baskets in each basketgroup

and maybe later :
- date of creation
- date of closure
- the list of baskets included in the basketgroup
- number of orders
- number received/non received orders


M. Saby
Comment 1 Mathieu Saby 2013-03-15 22:08:00 UTC Comment hidden (obsolete)
Comment 2 Koha Team University Lyon 3 2013-03-18 11:15:11 UTC
Tried on a sandbox : Applying: Bug 9806 : Add new columns to basket groups lists
Repository lacks necessary blobs to fall back on 3-way merge.
Comment 3 Mathieu Saby 2013-03-18 11:18:49 UTC
zut!
I will rebase it tomorrow.
M. Saby
Comment 4 Mathieu Saby 2013-03-18 11:23:26 UTC
you need to apply  BZ 9771 first. I suppose you cannot in a sandbox ;-)

M. Saby
Comment 5 Fridolin Somers 2013-03-18 13:27:38 UTC
(In reply to comment #3)
> zut!
> I will rebase it tomorrow.
> M. Saby

There are several whitespace changes in your patch.
You should split your patch into feature and cosmetic changes.
Comment 6 Mathieu Saby 2013-03-18 19:51:31 UTC Comment hidden (obsolete)
Comment 7 Mathieu Saby 2013-03-18 19:52:18 UTC Comment hidden (obsolete)
Comment 8 Mathieu Saby 2013-03-18 19:52:53 UTC
Still to apply on the top of 9771.

M. Saby
Comment 9 Mathieu Saby 2013-03-20 09:30:08 UTC
Comment on attachment 16309 [details] [review]
[PATCH 2/2] cosmetic patch (reindent part of basketgroup.tt)

Cosmetic patch is useless
M. saby
Comment 10 Owen Leonard 2013-03-20 12:44:09 UTC Comment hidden (obsolete)
Comment 11 Mathieu Saby 2013-03-21 15:22:01 UTC
Note : bz9771 has been pushed to master some minutes ago.
M. Saby
Comment 12 Fridolin Somers 2013-04-04 14:04:27 UTC
Why not using Koha::Template::Plugin::KohaBranchName to change branch code into branch description into template instead of into perl page ?
Comment 13 Mathieu Saby 2013-04-04 15:32:57 UTC
I did not know it was possible ;-)
If you think it is a better solution I will rewrite my patch.

Mathieu
Comment 14 Fridolin Somers 2013-04-04 16:02:34 UTC
I think it would be great.
Have a look at Bug 9229 patch to see how to do it.
Comment 15 Jonathan Druart 2013-05-03 08:46:54 UTC
I agree with the Fridolyn's proposal.
Marked as Failed QA.
Comment 16 Mathieu Saby 2013-05-03 09:07:57 UTC
I had forgotten this bug... Will take a look later and rewrite it.

Mathieu
Comment 17 Mathieu Saby 2013-05-18 13:35:14 UTC Comment hidden (obsolete)
Comment 18 Pierre Angot 2013-05-23 07:05:23 UTC
Test on sandbox :

Sandbox setup by tredok.pierre@gmail.com with database 2 and bug 9806 on Thu May 23 08:44:09 2013

Something went wrong !
Applying: Bug 9806 : Add new columns to basket groups lists
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
Applying: Bug 9806 : QA Followup - use template plugin for branch names
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 9806 : QA Followup - use template plugin for branch names
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
Bug 9806 - Show more information on basketgroups lists

[SIGNED-OFF] Bug 9806 : Add new columns to basket groups lists
Apply? [yn]
[PATCH 2] Bug 9806 : QA Followup - use template plugin for branch names
Apply? [yn]
Patch left in /tmp/PATCH-2-Bug-9806--QA-Followup---use-template-plugi-GS6lZO.patch
Comment 19 Jonathan Druart 2013-05-23 08:01:04 UTC
The patches apply correctly on a local instance. Switch back to Needs SO.
Comment 20 Mathieu Saby 2013-05-23 08:10:42 UTC
Thank you Jonathan. I could not check this morning, I am struggling with my VM...

Mathieu
Comment 21 Paul Poulain 2013-05-23 08:28:19 UTC
Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com>
Comment 22 Paul Poulain 2013-05-23 08:28:34 UTC Comment hidden (obsolete)
Comment 23 Mathieu Saby 2013-05-23 08:29:26 UTC
So, it is working? Your sandbox was not rightly set-up ?

Mathieu
Comment 24 Jonathan Druart 2013-05-23 08:56:36 UTC
QA comment:
Ergonomic improvement for the basket group table.
Simple patch, just add some columns on the table.
Marked as Passed QA.
Comment 25 Jonathan Druart 2013-05-23 08:57:06 UTC
Created attachment 18333 [details] [review]
Bug 9806 : Add new columns to basket groups lists

Revised to fix whitespace problems. Cosmetic changes put in an other patch.

In the list of all the open/closed basketgroups for a vendor, you just
have the name of each basketgroup, and 3 action buttons.
It is not sufficient for libraries using basketgroup.

Warning : this patch must be tested with BZ 9771 applied. If BZ 9771 is
not pushed to master when you test, apply it before.

This patch adds the following columns :
- number (id of basketgroup)
- billingplace (name of the library)
- deliveryplace (name of the library, or "free delivery place")
- number of baskets in each basketgroup

To test :
1) make some basketgroups with 0, 1, 2 baskets
2) make some basketgroups with different billing and deliveryplace
3) check the list of open and closed basketgroups
4) check action buttons are working like before

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

This is a nice improvement!

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 26 Jonathan Druart 2013-05-23 08:57:11 UTC
Created attachment 18334 [details] [review]
Bug 9806 : QA Followup - use template plugin for branch names

With this followup, instead of passing the real names of the branches to template file, only the branchcodes are passed.
The branchcodes are translated into branchnames in template file, using the KohaBranchName template plugin.

To test :
do the same test as for main patch :
1) make some basketgroups with 0, 1, 2 baskets
2) make some basketgroups with different billing and deliveryplace
3) check the list of open and closed basketgroups
4) check action buttons are working like before

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 27 Jonathan Druart 2013-05-23 08:57:14 UTC
Created attachment 18335 [details] [review]
Bug 9806: Remove single pixel on the basketgroup table

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 28 Jonathan Druart 2013-05-23 08:58:00 UTC
The last patch fixes a small issue with the Datatable sDom.
Comment 29 Mathieu Saby 2013-05-23 09:00:06 UTC
Jonathan, that's not my patch...
Comment 30 Jonathan Druart 2013-05-23 09:19:44 UTC
(In reply to comment #29)
> Jonathan, that's not my patch...

Hum... 2 first patchs is yours. Last one is mine. It is a QA followup. Do you disagree with it?
Comment 31 Mathieu Saby 2013-05-23 09:23:34 UTC
If it is a QA patch, that's ok!
In fact I did not look... I just look the title, and it reminds me an other bug, so I thought it as an attachement error.

Mathieu
Comment 32 Mathieu Saby 2013-05-23 09:24:51 UTC
(it reminds me BZ 10287)
Comment 33 Galen Charlton 2013-05-23 15:04:57 UTC
Pushed to master.  Thanks, Mathieu!