Bug 9008 introduced a nice warning message on the admin homepage for users logged in as the MySQL user. There is a link from the warning to create a patron, which looks like this: /cgi-bin/koha/members/memberentry.pl?op=add This takes me to a screen for adding an "Adult patron" (category code S), but when I save a patron it's actually saved with category code J, which is kind of weird... You'd probably want to create a "Librarian" patron, but since there is no way to know the category code that corresponds to "Librarian" in any given installation, I think it would be better if the link simply pointed to: /cgi-bin/koha/members/memberentry.pl where the desired category code can be chosen directly. There is also a small typo in the warning: "This a bad idea".
Sorry, typo. I think the link should be this: /cgi-bin/koha/members/members-home.pl
Created attachment 16344 [details] [review] Bug 9841 - Improve the link from the "logged in as mysql-user"-warning Currently, the link from the "logged in as mysql-user"-warning goes to add a patron in a seemingly random category code. This patch changes the link to point to Home › Patrons, where a category for the new patron can be chosen. A small typo in the warning message is also corrected. To test: - Apply the patch - Login as the MySQL user - Check that the warning appears on the intranet home page - Check that the typo in the first line is fixed: "This *is* a bad idea" - Check that the link in the warning leads to Home > Patrons
Created attachment 16358 [details] [review] Bug 9841 - Improve the link from the "logged in as mysql-user"-warning Currently, the link from the "logged in as mysql-user"-warning goes to add a patron in a seemingly random category code. This patch changes the link to point to Home › Patrons, where a category for the new patron can be chosen. A small typo in the warning message is also corrected. To test: - Apply the patch - Login as the MySQL user - Check that the warning appears on the intranet home page - Check that the typo in the first line is fixed: "This *is* a bad idea" - Check that the link in the warning leads to Home > Patrons Signed-off-by: Brendan <brendan@bywatersolutions.com>
Signed off and test plan was great. When clicking link - it dumped me to members-home where I could then choose which patron type I wanted. -Brendan
Created attachment 16366 [details] [review] [PASSED QA] Bug 9841 - Improve the link from the "logged in as mysql-user"-warning Currently, the link from the "logged in as mysql-user"-warning goes to add a patron in a seemingly random category code. This patch changes the link to point to Home > Patrons, where a category for the new patron can be chosen. A small typo in the warning message is also corrected. To test: - Apply the patch - Login as the MySQL user - Check that the warning appears on the intranet home page - Check that the typo in the first line is fixed: "This *is* a bad idea" - Check that the link in the warning leads to Home > Patrons Signed-off-by: Brendan <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All happy with this.
This patch has been pushed to master.
Pushed to 3.10.x will be in 3.10.5
Works as intended (tested with packages built off current master).