Bugzilla – Attachment 162947 Details for
Bug 33544
Squash some ILL fields to alleviate request table overflow
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33544: Link title in details to biblio
Bug-33544-Link-title-in-details-to-biblio.patch (text/plain), 3.71 KB, created by
Martin Renvoize (ashimema)
on 2024-03-08 08:16:13 UTC
(
hide
)
Description:
Bug 33544: Link title in details to biblio
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-03-08 08:16:13 UTC
Size:
3.71 KB
patch
obsolete
>From 6953d252b23daec0e1f13a79c2c0f9adbbc6c77b Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 4 Dec 2023 14:38:48 +0000 >Subject: [PATCH] Bug 33544: Link title in details to biblio > >This patch removes the biblio id column and instead adds the biblio link >to the title field in the request details column when appropriate. >--- > admin/columns_settings.yml | 2 -- > .../prog/en/includes/ill-list-table.inc | 1 - > koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js | 14 +++----------- > 3 files changed, 3 insertions(+), 14 deletions(-) > >diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml >index 0ba7ab141a1..2854e362ad9 100644 >--- a/admin/columns_settings.yml >+++ b/admin/columns_settings.yml >@@ -905,8 +905,6 @@ modules: > columnname: orderid > - > columnname: patron >- - >- columnname: biblio_id > - > columnname: library_branchname > - >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc >index 1c5ec6e8b1d..cf8b915b0c2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc >@@ -13,7 +13,6 @@ > <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="type" data-related-search-on="value">Request type</th> > <th scope="col">Order ID</th> > <th scope="col">Patron</th> >- <th scope="col">Bibliographic record ID</th> > <th scope="col">Library</th> > <th scope="col">Status</th> > <th scope="col" class="placed_formatted">Placed on</th> >diff --git a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js >index 89d5b9c72c3..5d920cb2359 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js >@@ -235,7 +235,9 @@ $(document).ready(function() { > if ( display_extended_attribute(row, 'article_title') !== "" ) { > display += '<span style="display:block"> Article: ' + display_extended_attribute(row, 'article_title') + '</span>'; > } >- if ( display_extended_attribute(row, 'title') !== "" ) { >+ if ( row.biblio_id !== null ) { >+ display += '<span style="display:block"> Title: ' + $biblio_to_html(row.biblio, { link: 1 }) + '</span>'; >+ } else if ( display_extended_attribute(row, 'title') !== "" ) { > display += '<span style="display:block"> Title: ' + display_extended_attribute(row, 'title') + '</span>'; > } > if ( display_extended_attribute(row, 'author') !== "" ) { >@@ -274,16 +276,6 @@ $(document).ready(function() { > "data": "patron.firstname:patron.surname:patron.cardnumber", > "render": function(data, type, row, meta) { > return (row.patron) ? $patron_to_html( row.patron, { display_cardnumber: true, url: true } ) : ''; } }, >- { >- "data": "biblio_id", >- "orderable": true, >- "render": function(data, type, row, meta) { >- if ( data === null ) { >- return ""; >- } >- return $biblio_to_html(row.biblio, { biblio_id_only: 1, link: 1 }); >- } >- }, > { > "data": "library.name", > "orderable": true, >-- >2.44.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33544
:
152860
|
152861
|
152862
|
152863
|
159528
|
159529
|
159530
|
162945
|
162946
| 162947