Bugzilla – Attachment 171182 Details for
Bug 37865
Use of uninitialized value $op in string at circulation.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37865: Fix uninitialized value warn
Bug-37865-Fix-uninitialized-value-warn.patch (text/plain), 1.27 KB, created by
Peter Vashchuk
on 2024-09-09 10:34:42 UTC
(
hide
)
Description:
Bug 37865: Fix uninitialized value warn
Filename:
MIME Type:
Creator:
Peter Vashchuk
Created:
2024-09-09 10:34:42 UTC
Size:
1.27 KB
patch
obsolete
>From 59608090a615b992f16adc75e5d85974793a6349 Mon Sep 17 00:00:00 2001 >From: Petro Vashchuk <stalkernoid@gmail.com> >Date: Mon, 9 Sep 2024 13:33:58 +0300 >Subject: [PATCH] Bug 37865: Fix uninitialized value warn > >Use of uninitialized value $op in string eq at /home/vagrant/kohaclone/circ/circulation.pl line 145.: /home/vagrant/kohaclone/circ/circulation.pl >This happened because in cases when $op was undef and circulation.pl tried to directly compare it to string. > >To reproduce: >1. Go to "Check Out" page of a patron, or refresh already opened one. >2. Check your logs for "Use of uninitialized value $op" warn. >3. Apply patch. >4. Repeat step 1 and check that there's no new "Use of uninitialized value $op" error >--- > circ/circulation.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/circ/circulation.pl b/circ/circulation.pl >index 9230347ce0..9e4d3ea5ea 100755 >--- a/circ/circulation.pl >+++ b/circ/circulation.pl >@@ -113,7 +113,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user ( > } > ); > >-my $op = $query->param('op'); >+my $op = $query->param('op') // ''; > my $override_high_holds = $query->param('override_high_holds'); > my $override_high_holds_tmp = $query->param('override_high_holds_tmp'); > >-- >2.46.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37865
:
171182
|
171185
|
171186
|
171187
|
171809
|
174257