Created attachment 171182 [details] [review] Bug 37865: Fix uninitialized value warn Use of uninitialized value $op in string eq at /home/vagrant/kohaclone/circ/circulation.pl line 145.: /home/vagrant/kohaclone/circ/circulation.pl This happened because in cases when $op was undef and circulation.pl tried to directly compare it to string. To reproduce: 1. Go to "Check Out" page of a patron, or refresh already opened one. 2. Check your logs for "Use of uninitialized value $op" warn. 3. Apply patch. 4. Repeat step 1 and check that there's no new "Use of uninitialized value $op" error
Created attachment 171185 [details] [review] Bug 37865: Fix uninitialized value $op warns [WARN] Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/circ/circulation.pl line 144. [WARN] Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/circ/returns.pl line 253. These happen in cases when $op is undef and circulation.pl or returns.pl tries to directly compare it to a string. To reproduce: 1. Go to "Check Out" and "Check In" circulation pages, or refresh already opened one. 2. Check your logs for "Use of uninitialized value $op" warning. 3. Apply patch. 4. Repeat step 1 and check that no new "Use of uninitialized value $op" error were logged.
Created attachment 171186 [details] [review] Bug 37865: Fix uninitialized value $op warns [WARN] Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/circ/circulation.pl line 144. [WARN] Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/circ/returns.pl line 253. These happen in cases when $op is undef and circulation.pl or returns.pl tries to directly compare it to a string. To reproduce: 1. Go to "Check Out" and "Check In" circulation pages, or refresh already opened one. 2. Check your logs for "Use of uninitialized value $op" warning. 3. Apply patch. 4. Repeat step 1 and check that no new "Use of uninitialized value $op" error were logged.
Created attachment 171187 [details] [review] Bug 37865: Fix uninitialized value $op warns [WARN] Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/circ/circulation.pl line 144. [WARN] Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/circ/returns.pl line 253. These happen in cases when $op is undef and circulation.pl or returns.pl tries to directly compare it to a string. To reproduce: 1. Go to "Check Out" and "Check In" circulation pages, or refresh already opened one. 2. Check your logs for "Use of uninitialized value $op" warning. 3. Apply patch. 4. Repeat step 1 and check that no new "Use of uninitialized value $op" error were logged.
Created attachment 171809 [details] [review] Bug 37865: Fix uninitialized value $op warns [WARN] Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/circ/circulation.pl line 144. [WARN] Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/circ/returns.pl line 253. These happen in cases when $op is undef and circulation.pl or returns.pl tries to directly compare it to a string. To reproduce: 1. Go to "Check Out" and "Check In" circulation pages, or refresh already opened one. 2. Check your logs for "Use of uninitialized value $op" warning. 3. Apply patch. 4. Repeat step 1 and check that no new "Use of uninitialized value $op" error were logged. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Created attachment 174257 [details] [review] Bug 37865: Fix uninitialized value $op warns [WARN] Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/circ/circulation.pl line 144. [WARN] Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/circ/returns.pl line 253. These happen in cases when $op is undef and circulation.pl or returns.pl tries to directly compare it to a string. To reproduce: 1. Go to "Check Out" and "Check In" circulation pages, or refresh already opened one. 2. Check your logs for "Use of uninitialized value $op" warning. 3. Apply patch. 4. Repeat step 1 and check that no new "Use of uninitialized value $op" error were logged. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Thomas Klausner <domm@plix.at>
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.06
Those vars does not exist in 23.11.x