Bugzilla – Attachment 176148 Details for
Bug 38738
additional-fields-entry.inc always closing select element even when it doesn't exist
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38738: Only close select element if needed
Bug-38738-Only-close-select-element-if-needed.patch (text/plain), 1.91 KB, created by
Jonathan Druart
on 2025-01-06 10:28:38 UTC
(
hide
)
Description:
Bug 38738: Only close select element if needed
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-01-06 10:28:38 UTC
Size:
1.91 KB
patch
obsolete
>From ba51c02d3670eea7c99aebbb5247e866f2c6e921 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Wed, 18 Dec 2024 11:02:51 +0000 >Subject: [PATCH] Bug 38738: Only close select element if needed > >Preparation: Create additional fields for table 'subscription', visit: >/cgi-bin/koha/admin/additional-fields.pl?tablename=subscription > >2 text fields, one repeatable, one not-repeatable >2 AV fields, one repeatable, one not-repeatable >2 MARC fields, one 'get' and one 'set', both non-repeatable, MARC field 942$c > >Test plan, apply both patches: >1) Add a new serial subscription, visit: >/cgi-bin/koha/serials/subscription-add.pl >2) Set the mandatory "Record" input (e.g. '112'). Click the 'Next' and press 'Ok' on the alert box. >3) Notice the message 'This message should only show if a select input is present' only shows for select inputs, i.e. it's only closing the element when it needs to > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > .../prog/en/includes/additional-fields-entry.inc | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc >index 4c42e905d31..c6561dbdafe 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc >@@ -76,7 +76,9 @@ > [% END %] > [% END %] > [% END %] >- </select> >+ [% IF field.marcfield || !field.repeatable %] >+ </select> >+ [% END %] > [% IF !search_form %] > <span>(Authorised values for [% authorised_value_category | html %])</span> > [% IF field.marcfield && field.marcfield_mode == 'get' %] >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38738
:
175641
|
175642
|
175680
| 176148