Bug 38738 - additional-fields-entry.inc always closing select element even when it doesn't exist
Summary: additional-fields-entry.inc always closing select element even when it doesn'...
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Pedro Amorim
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on: 35044
Blocks:
  Show dependency treegraph
 
Reported: 2024-12-18 11:08 UTC by Pedro Amorim
Modified: 2025-01-07 14:49 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 38738: Only close select element if needed (1.83 KB, patch)
2024-12-18 11:08 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 38738: [TEST ONLY] Add UI message for test (1.10 KB, patch)
2024-12-18 11:08 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 38738: [TEST ONLY] Add UI message for test (1.15 KB, patch)
2024-12-18 21:04 UTC, David Nind
Details | Diff | Splinter Review
Bug 38738: Only close select element if needed (1.91 KB, patch)
2025-01-06 10:28 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2024-12-18 11:08:00 UTC

    
Comment 1 Pedro Amorim 2024-12-18 11:08:47 UTC
Created attachment 175641 [details] [review]
Bug 38738: Only close select element if needed

Preparation: Create additional fields for table 'subscription', visit:
/cgi-bin/koha/admin/additional-fields.pl?tablename=subscription

2 text fields, one repeatable, one not-repeatable
2 AV fields, one repeatable, one not-repeatable
2 MARC fields, one 'get' and one 'set', both non-repeatable, MARC field 942$c

Test plan, apply both patches:
1) Add a new serial subscription, visit:
/cgi-bin/koha/serials/subscription-add.pl
2) Set the mandatory "Record" input (e.g. '112'). Click the 'Next' and press 'Ok' on the alert box.
3) Notice the message 'This message should only show if a select input is present' only shows for select inputs, i.e. it's only closing the element when it needs to
Comment 2 Pedro Amorim 2024-12-18 11:08:50 UTC
Created attachment 175642 [details] [review]
Bug 38738: [TEST ONLY] Add UI message for test
Comment 3 David Nind 2024-12-18 21:04:35 UTC
Created attachment 175680 [details] [review]
Bug 38738: [TEST ONLY] Add UI message for test

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Jonathan Druart 2025-01-06 10:28:38 UTC
Created attachment 176148 [details] [review]
Bug 38738: Only close select element if needed

Preparation: Create additional fields for table 'subscription', visit:
/cgi-bin/koha/admin/additional-fields.pl?tablename=subscription

2 text fields, one repeatable, one not-repeatable
2 AV fields, one repeatable, one not-repeatable
2 MARC fields, one 'get' and one 'set', both non-repeatable, MARC field 942$c

Test plan, apply both patches:
1) Add a new serial subscription, visit:
/cgi-bin/koha/serials/subscription-add.pl
2) Set the mandatory "Record" input (e.g. '112'). Click the 'Next' and press 'Ok' on the alert box.
3) Notice the message 'This message should only show if a select input is present' only shows for select inputs, i.e. it's only closing the element when it needs to

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Katrin Fischer 2025-01-07 14:49:19 UTC
Pushed for 25.05!

Well done everyone, thank you!