Created attachment 175641 [details] [review] Bug 38738: Only close select element if needed Preparation: Create additional fields for table 'subscription', visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=subscription 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 2 MARC fields, one 'get' and one 'set', both non-repeatable, MARC field 942$c Test plan, apply both patches: 1) Add a new serial subscription, visit: /cgi-bin/koha/serials/subscription-add.pl 2) Set the mandatory "Record" input (e.g. '112'). Click the 'Next' and press 'Ok' on the alert box. 3) Notice the message 'This message should only show if a select input is present' only shows for select inputs, i.e. it's only closing the element when it needs to
Created attachment 175642 [details] [review] Bug 38738: [TEST ONLY] Add UI message for test
Created attachment 175680 [details] [review] Bug 38738: [TEST ONLY] Add UI message for test Signed-off-by: David Nind <david@davidnind.com>
Created attachment 176148 [details] [review] Bug 38738: Only close select element if needed Preparation: Create additional fields for table 'subscription', visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=subscription 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 2 MARC fields, one 'get' and one 'set', both non-repeatable, MARC field 942$c Test plan, apply both patches: 1) Add a new serial subscription, visit: /cgi-bin/koha/serials/subscription-add.pl 2) Set the mandatory "Record" input (e.g. '112'). Click the 'Next' and press 'Ok' on the alert box. 3) Notice the message 'This message should only show if a select input is present' only shows for select inputs, i.e. it's only closing the element when it needs to Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed for 25.05! Well done everyone, thank you!