Bugzilla – Attachment 179232 Details for
Bug 33544
Squash some ILL fields to alleviate request table overflow
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33544: Link title in details to biblio
Bug-33544-Link-title-in-details-to-biblio.patch (text/plain), 3.67 KB, created by
Lisette Scheer
on 2025-03-12 20:03:47 UTC
(
hide
)
Description:
Bug 33544: Link title in details to biblio
Filename:
MIME Type:
Creator:
Lisette Scheer
Created:
2025-03-12 20:03:47 UTC
Size:
3.67 KB
patch
obsolete
>From 006b6ba57ebf823991285e1135bb4e866ea554fb Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 4 Dec 2023 14:38:48 +0000 >Subject: [PATCH] Bug 33544: Link title in details to biblio > >This patch removes the biblio id column and instead adds the biblio link >to the title field in the request details column when appropriate. > >Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> >--- > admin/columns_settings.yml | 2 -- > .../prog/en/includes/ill-list-table.inc | 1 - > .../intranet-tmpl/prog/js/ill-list-table.js | 22 +++++++------------ > 3 files changed, 8 insertions(+), 17 deletions(-) > >diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml >index adf8da43806..e0e94bf2b71 100644 >--- a/admin/columns_settings.yml >+++ b/admin/columns_settings.yml >@@ -1064,8 +1064,6 @@ modules: > columnname: orderid > - > columnname: patron >- - >- columnname: biblio_id > - > columnname: library_branchname > - >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc >index abf1d1f15fa..c924d7281a8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc >@@ -13,7 +13,6 @@ > <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="type" data-related-search-on="value">Request type</th> > <th scope="col">Order ID</th> > <th scope="col">Patron</th> >- <th scope="col">Bibliographic record ID</th> > <th scope="col">Library</th> > <th scope="col">Status</th> > <th scope="col" class="placed_formatted">Placed on</th> >diff --git a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js >index 84bac7ea965..fcd16e0bde4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js >@@ -286,7 +286,14 @@ $(document).ready(function () { > ) + > "</span>"; > } >- if (display_extended_attribute(row, "title") !== "") { >+ if (row.biblio_id !== null) { >+ display += >+ '<span style="display:block"> Title: ' + >+ $biblio_to_html(row.biblio, { link: 1 }) + >+ "</span>"; >+ } else if ( >+ display_extended_attribute(row, "title") !== "" >+ ) { > display += > '<span style="display:block"> Title: ' + > display_extended_attribute(row, "title") + >@@ -364,19 +371,6 @@ $(document).ready(function () { > : ""; > }, > }, >- { >- data: "biblio_id", >- orderable: true, >- render: function (data, type, row, meta) { >- if (data === null) { >- return ""; >- } >- return $biblio_to_html(row.biblio, { >- biblio_id_only: 1, >- link: 1, >- }); >- }, >- }, > { > data: "library.name", > orderable: true, >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33544
:
152860
|
152861
|
152862
|
152863
|
159528
|
159529
|
159530
|
162945
|
162946
|
162947
|
179227
|
179228
|
179229
| 179232 |
179233
|
179234