Bugzilla – Attachment 180490 Details for
Bug 39543
Error modal when trying to add two controlling licences to an agreement duplicates error message
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39543: Remove duplicated code in agreements controlling licence error message Test plan 1) Enable ERMModule sys pref 2) Add an agreement record 3) Add two licence records 4) Edit the agreement record and associate both license records to the agreement
Bug-39543-Remove-duplicated-code-in-agreements-con.patch (text/plain), 1.66 KB, created by
Andrew Auld
on 2025-04-03 10:45:24 UTC
(
hide
)
Description:
Bug 39543: Remove duplicated code in agreements controlling licence error message Test plan 1) Enable ERMModule sys pref 2) Add an agreement record 3) Add two licence records 4) Edit the agreement record and associate both license records to the agreement
Filename:
MIME Type:
Creator:
Andrew Auld
Created:
2025-04-03 10:45:24 UTC
Size:
1.66 KB
patch
obsolete
>From 10434705f5f7af9a7e389db6a982c81a20cea4aa Mon Sep 17 00:00:00 2001 >From: Andrew Auld <andrew.auld@openfifth.co.uk> >Date: Thu, 3 Apr 2025 10:34:47 +0000 >Subject: [PATCH] Bug 39543: Remove duplicated code in agreements controlling > licence error message Test plan 1) Enable ERMModule sys pref 2) Add an > agreement record 3) Add two licence records 4) Edit the agreement record and > associate both license records to the agreement 5) Try to set both licenses > to status 'controlling' 6) Note error modal duplicates the error message > 'Only one controlling license is allowed' 7) Apply the patch, run yarn > js:build and then hard refresh the browser 8) Repeat steps 1 to 5 and enjoy > the single error message! > >--- > .../prog/js/vue/components/ERM/AgreementsFormAdd.vue | 9 --------- > 1 file changed, 9 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue >index 643bb0acc4..3b4412430a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue >@@ -292,15 +292,6 @@ export default { > ); > } > >- if ( >- agreement_licenses.filter(al => al.status == "controlling") >- .length > 1 >- ) { >- errors.push( >- this.$__("Only one controlling license is allowed") >- ); >- } >- > let documents_with_uploaded_files = agreement.documents.filter( > doc => typeof doc.file_content !== "undefined" > ); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39543
:
180488
|
180490
|
180491
|
180526