Created attachment 180488 [details] Screenshot of error modal If you try to add two licences with the status 'controlling' to an agreement record, the error modal duplicates the error message 'Only one controlling license is allowed'.
Created attachment 180490 [details] [review] Bug 39543: Remove duplicated code in agreements controlling licence error message Test plan 1) Enable ERMModule sys pref 2) Add an agreement record 3) Add two licence records 4) Edit the agreement record and associate both license records to the agreement
Sorry for the duff formatting on the test plan: Test Plan: 1) Enable ERMModule sys pref 2) Add an agreement record 3) Add two licence records 4) Edit the agreement record and associate both license records to the agreement 5) Try to set both licenses to status 'controlling' 6) Note error modal duplicates the error message 'Only one controlling license is allowed' 7) Apply the patch, run yarn js:build and then hard refresh the browser 8) Repeat steps 1 to 5 and enjoy the single error message!
Created attachment 180491 [details] [review] Bug 39543: Error modal when trying to add two controlling licences to an agreement duplicates error message If you try to add two licences with the status 'controlling' to an agreement record, the error modal duplicates the error message 'Only one controlling license is allowed'. Test Plan: 1) Enable ERMModule sys pref 2) Add an agreement record 3) Add two licence records 4) Edit the agreement record and associate both license records to the agreement 5) Try to set both licenses to status 'controlling' 6) Note error modal duplicates the error message 'Only one controlling license is allowed' 7) Apply the patch, run yarn js:build and then hard refresh the browser 8) Repeat steps 1 to 5 and enjoy the single error message! Signed-off-by: Magnus Enger <magnus@libriotech.no> I took the liberty of fixing up the commit message a bit.
Created attachment 180526 [details] [review] Bug 39543: Error modal when trying to add two controlling licences to an agreement duplicates error message If you try to add two licences with the status 'controlling' to an agreement record, the error modal duplicates the error message 'Only one controlling license is allowed'. Test Plan: 1) Enable ERMModule sys pref 2) Add an agreement record 3) Add two licence records 4) Edit the agreement record and associate both license records to the agreement 5) Try to set both licenses to status 'controlling' 6) Note error modal duplicates the error message 'Only one controlling license is allowed' 7) Apply the patch, run yarn js:build and then hard refresh the browser 8) Repeat steps 1 to 5 and enjoy the single error message! Signed-off-by: Magnus Enger <magnus@libriotech.no> I took the liberty of fixing up the commit message a bit. Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>