Bugzilla – Attachment 71438 Details for
Bug 20144
Test suite is failing with new default SQL modes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20144: [sql_modes] Set default value for marc_modification_template_actions
Bug-20144-sqlmodes-Set-default-value-for-marcmodif.patch (text/plain), 1.56 KB, created by
Julian Maurice
on 2018-02-12 11:06:42 UTC
(
hide
)
Description:
Bug 20144: [sql_modes] Set default value for marc_modification_template_actions
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2018-02-12 11:06:42 UTC
Size:
1.56 KB
patch
obsolete
>From 10fd98f48558f8addd71df1154c52bcd4b05f45b Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 5 Feb 2018 18:40:36 -0300 >Subject: [PATCH] Bug 20144: [sql_modes] Set default value for > marc_modification_template_actions > >Cannot be empty strings. > >Fix for: >Data truncated for column 'conditional' >Data truncated for column 'conditional_comparison' >Incorrect integer value: '' for column 'conditional_regex' > >t/db_dependent/MarcModificationTemplates.t > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > C4/MarcModificationTemplates.pm | 5 +++++ > 1 file changed, 5 insertions(+) > >diff --git a/C4/MarcModificationTemplates.pm b/C4/MarcModificationTemplates.pm >index bbfb1c6470..3932e806b4 100644 >--- a/C4/MarcModificationTemplates.pm >+++ b/C4/MarcModificationTemplates.pm >@@ -240,6 +240,8 @@ sub AddModificationTemplateAction { > $to_regex_search, $to_regex_replace, $to_regex_modifiers, $conditional, $conditional_field, $conditional_subfield, $conditional_comparison, > $conditional_value, $conditional_regex, $description )" ) if DEBUG; > >+ $conditional ||= undef; >+ $conditional_comparison ||= undef; > $conditional_regex ||= '0'; > > my $dbh = C4::Context->dbh; >@@ -337,6 +339,9 @@ sub ModModificationTemplateAction { > ) = @_; > > my $dbh = C4::Context->dbh; >+ $conditional ||= undef; >+ $conditional_comparison ||= undef; >+ $conditional_regex ||= '0'; > > my $query = " > UPDATE marc_modification_template_actions SET >-- >2.14.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20144
:
71410
|
71411
|
71412
|
71413
|
71414
|
71415
|
71416
|
71417
|
71418
|
71419
|
71420
|
71421
|
71422
|
71423
|
71424
|
71425
|
71427
|
71428
|
71429
|
71430
|
71431
|
71432
|
71434
|
71435
|
71436
|
71437
| 71438 |
71440
|
71441
|
71442
|
71443
|
71444
|
71445
|
71446
|
71447
|
71448
|
71449
|
71450
|
71451
|
71452
|
71453
|
71454
|
71455
|
71456
|
71457
|
71458
|
71459
|
71460
|
71461
|
71462
|
71463
|
71467
|
71564