Attachment 71455 Details for Bug 20144 – Bug 20144: [sql_modes] Set value for creator_batches.timestamp

[patch] Bug 20144: [sql_modes] Set value for creator_batches.timestamp

Bug-20144-sqlmodes-Set-value-for-creatorbatchestim.patch (text/plain), 1.64 KB, created by Julian Maurice on 2018-02-12 12:37:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2018-02-12 12:37:47 UTC

Size: 1.64 KB

patch

obsolete

>From 24d8b089f6781c6d12bdb896fd62d8e66ea074d3 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 6 Feb 2018 13:28:38 -0300
>Subject: [PATCH] Bug 20144: [sql_modes] Set value for
> creator_batches.timestamp
>
>Fix for:
>Incorrect datetime value: 'now()' for column 'timestamp'
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
>---
> t/db_dependent/Creators/Lib.t | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/t/db_dependent/Creators/Lib.t b/t/db_dependent/Creators/Lib.t
>index 248c4e76d9..858b886dad 100644
>--- a/t/db_dependent/Creators/Lib.t
>+++ b/t/db_dependent/Creators/Lib.t
>@@ -238,13 +238,13 @@ $query = '
>   INSERT INTO creator_batches
>     (batch_id , item_number, borrower_number,
>      timestamp, branch_code, creator)
>-  VALUES (?,?,?,?,?,?)';
>+  VALUES (?,?,?,NOW(),?,?)';
> $insert_sth = $dbh->prepare($query);
>-$insert_sth->execute( 11, $item_number1, $borrowernumber1, 'now()', $library1->{branchcode}, 'Labels' );
>+$insert_sth->execute( 11, $item_number1, $borrowernumber1, $library1->{branchcode}, 'Labels' );
> 
>-$insert_sth->execute( 12, $item_number2, $borrowernumber2, 'now()', $library2->{branchcode}, 'Labels' );
>+$insert_sth->execute( 12, $item_number2, $borrowernumber2, $library2->{branchcode}, 'Labels' );
> 
>-$insert_sth->execute( 12, $item_number3, $borrowernumber3, 'now()', $library3->{branchcode}, 'Labels' );
>+$insert_sth->execute( 12, $item_number3, $borrowernumber3, $library3->{branchcode}, 'Labels' );
> 
> ###########################################################
> #                     Testing Subs
>-- 
>2.14.2

Actions: View | Diff | Splinter Review

Attachments on bug 20144: 71410 | 71411 | 71412 | 71413 | 71414 | 71415 | 71416 | 71417 | 71418 | 71419 | 71420 | 71421 | 71422 | 71423 | 71424 | 71425 | 71427 | 71428 | 71429 | 71430 | 71431 | 71432 | 71434 | 71435 | 71436 | 71437 | 71438 | 71440 | 71441 | 71442 | 71443 | 71444 | 71445 | 71446 | 71447 | 71448 | 71449 | 71450 | 71451 | 71452 | 71453 | 71454 | 71455 | 71456 | 71457 | 71458 | 71459 | 71460 | 71461 | 71462 | 71463 | 71467 | 71564