Bugzilla – Attachment 75150 Details for
Bug 20726
Display acquisition details on the subscription detail page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20726: Remove GetLastOrder* subroutines
Bug-20726-Remove-GetLastOrder-subroutines.patch (text/plain), 2.47 KB, created by
Jonathan Druart
on 2018-05-07 23:50:37 UTC
(
hide
)
Description:
Bug 20726: Remove GetLastOrder* subroutines
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-05-07 23:50:37 UTC
Size:
2.47 KB
patch
obsolete
>From c74993ff3baa55a141f65dc42a4181ff6edee8e7 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 7 May 2018 20:49:16 -0300 >Subject: [PATCH] Bug 20726: Remove GetLastOrder* subroutines > >They are not used elsewhere. >--- > t/db_dependent/Acquisition/OrderFromSubscription.t | 15 ++------------- > 1 file changed, 2 insertions(+), 13 deletions(-) > >diff --git a/t/db_dependent/Acquisition/OrderFromSubscription.t b/t/db_dependent/Acquisition/OrderFromSubscription.t >index cc691d0585..3d2859b99f 100644 >--- a/t/db_dependent/Acquisition/OrderFromSubscription.t >+++ b/t/db_dependent/Acquisition/OrderFromSubscription.t >@@ -1,6 +1,6 @@ > use Modern::Perl; > >-use Test::More tests => 12; >+use Test::More tests => 7; > > use t::lib::TestBuilder; > >@@ -80,10 +80,6 @@ my $ordernumber = $order->ordernumber; > my $is_currently_on_order = subscriptionCurrentlyOnOrder( $subscription->{subscriptionid} ); > is ( $is_currently_on_order, 1, "The subscription is currently on order"); > >-$order = GetLastOrderNotReceivedFromSubscriptionid( $subscription->{subscriptionid} ); >-is ( $order->{subscriptionid}, $subscription->{subscriptionid}, "test subscriptionid for the last order not received"); >-ok( $order->{ecost} == $cost, "test cost for the last order not received"); >- > $dbh->do(q{DELETE FROM aqinvoices}); > my $invoiceid = AddInvoice(invoicenumber => 'invoice1', booksellerid => $bookseller->id, unknown => "unknown"); > >@@ -93,20 +89,13 @@ $invoice->{datereceived} = '2013-01-02'; > my ( $datereceived, $new_ordernumber ) = ModReceiveOrder( > { > biblionumber => $biblionumber, >- order => $order, >+ order => $order->unblessed, > quantityreceived => 1, > budget_id => $budget_id, > invoice => $invoice, > } > ); > >-$order = GetLastOrderReceivedFromSubscriptionid( $subscription->{subscriptionid} ); >-is ( $order->{subscriptionid}, $subscription->{subscriptionid}, "test subscriptionid for the last order received"); >-ok( $order->{ecost} == $cost, "test cost for the last order received"); >- >-$order = GetLastOrderNotReceivedFromSubscriptionid( $subscription->{subscriptionid} ); >-is ( $order, undef, "test no not received order for a received order"); >- > my @invoices = GetInvoices(); > my @invoices_linked_to_subscriptions = grep { $_->{is_linked_to_subscriptions} } @invoices; > is(scalar(@invoices_linked_to_subscriptions), 1, 'GetInvoices() can identify invoices that are linked to a subscription'); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20726
:
75146
|
75147
|
75148
|
75149
|
75150
|
75650
|
75651
|
75666
|
75708
|
75709
|
75710
|
75711
|
75712
|
75713
|
75794
|
77428
|
77429
|
77430
|
77431
|
77432
|
77433
|
77434
|
77500
|
77501
|
77502
|
77503
|
77504
|
77505
|
77506
|
78062
|
78063
|
78064
|
78065
|
78066
|
78067
|
78068