Bugzilla – Attachment 27103 Details for
Bug 10823
add class info to enumchron data in detail.tt, for better styling
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10823 - add class info to enumchron data in detail.tt, for better styling
Bug-10823---add-class-info-to-enumchron-data-in-de.patch (text/plain), 3.51 KB, created by
Mark Tompsett
on 2014-04-14 18:42:20 UTC
(
hide
)
Description:
Bug 10823 - add class info to enumchron data in detail.tt, for better styling
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2014-04-14 18:42:20 UTC
Size:
3.51 KB
patch
obsolete
>From 7d9986dd4bf09ca2dc29d81e43cf616ede8f54b1 Mon Sep 17 00:00:00 2001 >From: Mason James <mtj@kohaaloha.com> >Date: Tue, 15 Apr 2014 00:11:16 +1200 >Subject: [PATCH] Bug 10823 - add class info to enumchron data in detail.tt, > for better styling > >Bug 10825 removes a duplicate (enumchron==serialseq). >This patch was developed on top of it. It properly styles >the elements. These include: >- items.enumchron >- the separator used >- serial.serialseq >- items.publisheddate > >As per Katrin's and Owen's suggestion, <span> was used instead >of <div>. (See comment #7 and >http://irc.koha-community.org/koha/2014-04-03#i_1491135) > >TEST PLAN >--------- >1) Apply patch 10825 >2) Find a biblio where the enumchron and serialseq are different. > -- in MySQL: > SELECT items.biblionumber,items.enumchron,serial.serialseq > FROM items,serial,serialitems > WHERE items.itemnumber=serilaitems.itemnumber > AND serialitems.serialid=serial.serialid; >3) In the staff client, view the source for that item. > -- It should be one class for the entire <td> cell. >4) Apply patch 10823 >5) Refresh the page >6) Look at the source for that item again. > -- It should have <span> tags around the 4 things listed > above. >7) Run the koha qa test tools. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >NOTE: Since there was lots of squashing and rebasing, could you > please test and sign this off as well, Mason? >--- > .../prog/en/modules/catalogue/detail.tt | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index d09a3c4..97c4267d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -659,17 +659,19 @@ function verify_images() { > <td class="enumchron"> > [% IF ( itemdata_enumchron ) %] > [% IF item.enumchron && item.serialseq %] >- [% item.enumchron %] >- [% IF ( item.serialseq && >- item.enumchron!=item.serialseq ) %] >- -- [% item.serialseq %] >+ <span class="enum">[% item.enumchron %]</span> >+ [% IF ( item.serialseq && item.enumchron!=item.serialseq ) %] >+ <span class="sep"> -- </span> >+ <span class="serialseq">[% item.serialseq %]</span> > [% END %] > [% ELSIF item.enumchron %] >- [% item.enumchron %] >+ <span class="enum">[% item.enumchron %]</span> > [% ELSIF item.serialseq %] >- [% item.serialseq %] >+ <span class="serialseq">[% item.serialseq %]</span> >+ [% END %] >+ [% IF ( item.publisheddate ) %] >+ <span class="pubdate">([% item.publisheddate %])</span> > [% END %] >- [% IF ( item.publisheddate ) %] ([% item.publisheddate %])[% END %] > [% END %] > </td> > [% END %] >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10823
:
20790
|
26709
|
27073
|
27074
|
27075
|
27085
|
27086
|
27087
|
27091
|
27092
|
27103
|
27536
|
27650