Bugzilla – Attachment 71411 Details for
Bug 20144
Test suite is failing with new default SQL modes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20144: [sql_modes] Set a default value for lowestPriority
Bug-20144-sqlmodes-Set-a-default-value-for-lowestP.patch (text/plain), 3.35 KB, created by
Julian Maurice
on 2018-02-12 09:23:50 UTC
(
hide
)
Description:
Bug 20144: [sql_modes] Set a default value for lowestPriority
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2018-02-12 09:23:50 UTC
Size:
3.35 KB
patch
obsolete
>From 842d163bf3bc404a3ef181c667aed174d571c164 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 5 Feb 2018 14:33:45 -0300 >Subject: [PATCH] Bug 20144: [sql_modes] Set a default value for lowestPriority > >Fix for: >Field 'lowestPriority' doesn't have a default value > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > .../data/mysql/atomicupdate/bug_xxxxx_reserves.lowestPriority.sql | 2 ++ > installer/data/mysql/kohastructure.sql | 4 ++-- > 2 files changed, 4 insertions(+), 2 deletions(-) > create mode 100644 installer/data/mysql/atomicupdate/bug_xxxxx_reserves.lowestPriority.sql > >diff --git a/installer/data/mysql/atomicupdate/bug_xxxxx_reserves.lowestPriority.sql b/installer/data/mysql/atomicupdate/bug_xxxxx_reserves.lowestPriority.sql >new file mode 100644 >index 0000000000..2eac0baefe >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_xxxxx_reserves.lowestPriority.sql >@@ -0,0 +1,2 @@ >+ALTER TABLE reserves MODIFY lowestPriority tinyint(1) NOT NULL DEFAULT 0; >+ALTER TABLE old_reserves MODIFY lowestPriority tinyint(1) NOT NULL DEFAULT 0; >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index f8fcf04c91..74d1a01c64 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -1895,7 +1895,7 @@ CREATE TABLE `reserves` ( -- information related to holds/reserves in Koha > `itemnumber` int(11) default NULL, -- foreign key from the items table defining the specific item the patron has placed on hold or the item this hold was filled with > `waitingdate` date default NULL, -- the date the item was marked as waiting for the patron at the library > `expirationdate` DATE DEFAULT NULL, -- the date the hold expires (usually the date entered by the patron to say they don't need the hold after a certain date) >- `lowestPriority` tinyint(1) NOT NULL, >+ `lowestPriority` tinyint(1) NOT NULL DEFAULT 0, > `suspend` BOOLEAN NOT NULL DEFAULT 0, > `suspend_until` DATETIME NULL DEFAULT NULL, > `itemtype` VARCHAR(10) NULL DEFAULT NULL, -- If record level hold, the optional itemtype of the item the patron is requesting >@@ -1934,7 +1934,7 @@ CREATE TABLE `old_reserves` ( -- this table holds all holds/reserves that have b > `itemnumber` int(11) default NULL, -- foreign key from the items table defining the specific item the patron has placed on hold or the item this hold was filled with > `waitingdate` date default NULL, -- the date the item was marked as waiting for the patron at the library > `expirationdate` DATE DEFAULT NULL, -- the date the hold expires (usually the date entered by the patron to say they don't need the hold after a certain date) >- `lowestPriority` tinyint(1) NOT NULL, -- has this hold been pinned to the lowest priority in the holds queue (1 for yes, 0 for no) >+ `lowestPriority` tinyint(1) NOT NULL DEFAULT 0, -- has this hold been pinned to the lowest priority in the holds queue (1 for yes, 0 for no) > `suspend` BOOLEAN NOT NULL DEFAULT 0, -- in this hold suspended (1 for yes, 0 for no) > `suspend_until` DATETIME NULL DEFAULT NULL, -- the date this hold is suspended until (NULL for infinitely) > `itemtype` VARCHAR(10) NULL DEFAULT NULL, -- If record level hold, the optional itemtype of the item the patron is requesting >-- >2.14.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20144
:
71410
| 71411 |
71412
|
71413
|
71414
|
71415
|
71416
|
71417
|
71418
|
71419
|
71420
|
71421
|
71422
|
71423
|
71424
|
71425
|
71427
|
71428
|
71429
|
71430
|
71431
|
71432
|
71434
|
71435
|
71436
|
71437
|
71438
|
71440
|
71441
|
71442
|
71443
|
71444
|
71445
|
71446
|
71447
|
71448
|
71449
|
71450
|
71451
|
71452
|
71453
|
71454
|
71455
|
71456
|
71457
|
71458
|
71459
|
71460
|
71461
|
71462
|
71463
|
71467
|
71564