Bugzilla – Attachment 71459 Details for
Bug 20144
Test suite is failing with new default SQL modes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20144: [sql_modes] Fix values when creating a sql report in tests
Bug-20144-sqlmodes-Fix-values-when-creating-a-sql-.patch (text/plain), 1.64 KB, created by
Julian Maurice
on 2018-02-12 12:48:41 UTC
(
hide
)
Description:
Bug 20144: [sql_modes] Fix values when creating a sql report in tests
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2018-02-12 12:48:41 UTC
Size:
1.64 KB
patch
obsolete
>From b0fb07d8bb6cb754f5a28a067101a970c1d46c66 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 6 Feb 2018 14:39:32 -0300 >Subject: [PATCH] Bug 20144: [sql_modes] Fix values when creating a sql report > in tests > >For fix: >Data too long for column 'report_area' >Incorrect integer value: 'null' for column 'cache_expiry' > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > t/db_dependent/Reports/Guided.t | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/t/db_dependent/Reports/Guided.t b/t/db_dependent/Reports/Guided.t >index 0a2c734447..2de73402ee 100644 >--- a/t/db_dependent/Reports/Guided.t >+++ b/t/db_dependent/Reports/Guided.t >@@ -186,19 +186,19 @@ subtest 'get_saved_reports' => sub { > is( $count, 0, "There is no report" ); > > my @report_ids; >- foreach ( 1..3 ) { >+ foreach my $ii ( 1..3 ) { > my $id = $builder->build({ source => 'Borrower' })->{ borrowernumber }; > push @report_ids, save_report({ > borrowernumber => $id, > sql => "SQL$id", > name => "Name$id", >- area => "area$id", >+ area => "area$ii", # ii vs id area is varchar(6) > group => "group$id", > subgroup => "subgroup$id", > type => "type$id", > notes => "note$id", >- cache_expiry => "null", >- public => "null" >+ cache_expiry => undef, >+ public => 0, > }); > $count++; > } >-- >2.14.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20144
:
71410
|
71411
|
71412
|
71413
|
71414
|
71415
|
71416
|
71417
|
71418
|
71419
|
71420
|
71421
|
71422
|
71423
|
71424
|
71425
|
71427
|
71428
|
71429
|
71430
|
71431
|
71432
|
71434
|
71435
|
71436
|
71437
|
71438
|
71440
|
71441
|
71442
|
71443
|
71444
|
71445
|
71446
|
71447
|
71448
|
71449
|
71450
|
71451
|
71452
|
71453
|
71454
|
71455
|
71456
|
71457
|
71458
| 71459 |
71460
|
71461
|
71462
|
71463
|
71467
|
71564