Summary: | can't print more than one page of overdues | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Browser compatibility | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle.m.hall |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6291 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 10108 - can't print more than one page of overdues
[SIGNED-OFF] Bug 10108 - can't print more than one page of overdues [PASSED QA] Bug 10108 - can't print more than one page of overdues |
Description
Nicole C. Engard
2013-04-24 18:52:40 UTC
This actually happens with all reports- not just the overdues one. Confirmed in master. > Confirmed in master. Correction: Confirmed in master when using Firefox (on both Windows 7 and Ubuntu). The problem doesn't show when using Chrome or Opera. This sounds like Bug 6291 which unfortunately didn't exactly get a "real" fix. Created attachment 18082 [details] [review] Bug 10108 - can't print more than one page of overdues Printing a report like overdues in Firefox results in a printout which cuts off in the middle. I traced the cause to something in the YUI grid system, although I'm not sure what specific definition is the cause. This patch adds a "screen" parameter to the @import which loads the YUI grid CSS file. This will disable YUI grid layouts in print views. The main disadvantage to this, as far as I can tell, is that it will "linearize" some layouts. For instance: the patron detail page (moremember.pl) which on screen is divided into two columns. I think this disadvantage is outweighed by the ability to make complete prints. To test, apply the patch and clear your cache. Try printing various reports from Firefox. Printouts should look correct and be complete. Should this work for reports run from the saved reports page? Because it doesn't appear to be. I have 200 lines set to show and then I print but only get 1 page. It is working for the Holds Queue though. (In reply to comment #5) > Should this work for reports run from the saved reports page? It works in my tests. Can you try again? Created attachment 18134 [details] [review] [SIGNED-OFF] Bug 10108 - can't print more than one page of overdues Printing a report like overdues in Firefox results in a printout which cuts off in the middle. I traced the cause to something in the YUI grid system, although I'm not sure what specific definition is the cause. This patch adds a "screen" parameter to the @import which loads the YUI grid CSS file. This will disable YUI grid layouts in print views. The main disadvantage to this, as far as I can tell, is that it will "linearize" some layouts. For instance: the patron detail page (moremember.pl) which on screen is divided into two columns. I think this disadvantage is outweighed by the ability to make complete prints. To test, apply the patch and clear your cache. Try printing various reports from Firefox. Printouts should look correct and be complete. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> all tests pass Created attachment 18140 [details] [review] [PASSED QA] Bug 10108 - can't print more than one page of overdues Printing a report like overdues in Firefox results in a printout which cuts off in the middle. I traced the cause to something in the YUI grid system, although I'm not sure what specific definition is the cause. This patch adds a "screen" parameter to the @import which loads the YUI grid CSS file. This will disable YUI grid layouts in print views. The main disadvantage to this, as far as I can tell, is that it will "linearize" some layouts. For instance: the patron detail page (moremember.pl) which on screen is divided into two columns. I think this disadvantage is outweighed by the ability to make complete prints. To test, apply the patch and clear your cache. Try printing various reports from Firefox. Printouts should look correct and be complete. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> all tests pass Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> CSS only change, no strings involved. Tested with a saved SQL report 'select * from borrowers'. This patch has been pushed to master and 3.12.x. |