Bug 10108 - can't print more than one page of overdues
Summary: can't print more than one page of overdues
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Browser compatibility (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-24 18:52 UTC by Nicole C. Engard
Modified: 2014-12-07 20:02 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10108 - can't print more than one page of overdues (1.58 KB, patch)
2013-05-10 19:38 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10108 - can't print more than one page of overdues (1.63 KB, patch)
2013-05-14 12:59 UTC, Nicole C. Engard
Details | Diff | Splinter Review
[PASSED QA] Bug 10108 - can't print more than one page of overdues (1.78 KB, patch)
2013-05-15 05:22 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2013-04-24 18:52:40 UTC
There is no way to print more than one page of the overdues report found in the circulation module. When you choose to print it stops after the first page in all tests I've run.
Comment 1 Nicole C. Engard 2013-04-29 21:13:12 UTC
This actually happens with all reports- not just the overdues one.
Comment 2 Owen Leonard 2013-05-10 16:24:43 UTC
Confirmed in master.
Comment 3 Owen Leonard 2013-05-10 16:39:47 UTC
> Confirmed in master.

Correction: Confirmed in master when using Firefox (on both Windows 7 and Ubuntu). The problem doesn't show when using Chrome or Opera. This sounds like Bug 6291 which unfortunately didn't exactly get a "real" fix.
Comment 4 Owen Leonard 2013-05-10 19:38:51 UTC Comment hidden (obsolete)
Comment 5 Nicole C. Engard 2013-05-10 20:32:28 UTC
Should this work for reports run from the saved reports page? Because it doesn't appear to be. I have 200 lines set to show and then I print but only get 1 page.  It is working for the Holds Queue though.
Comment 6 Owen Leonard 2013-05-14 12:33:04 UTC
(In reply to comment #5)
> Should this work for reports run from the saved reports page?

It works in my tests. Can you try again?
Comment 7 Nicole C. Engard 2013-05-14 12:59:39 UTC Comment hidden (obsolete)
Comment 8 Katrin Fischer 2013-05-15 05:22:32 UTC
Created attachment 18140 [details] [review]
[PASSED QA] Bug 10108 - can't print more than one page of overdues

Printing a report like overdues in Firefox results in a printout which
cuts off in the middle. I traced the cause to something in the YUI grid
system, although I'm not sure what specific definition is the cause.

This patch adds a "screen" parameter to the @import which loads the YUI
grid CSS file. This will disable YUI grid layouts in print views. The
main disadvantage to this, as far as I can tell, is that it will
"linearize" some layouts. For instance: the patron detail page
(moremember.pl) which on screen is divided into two columns. I think
this disadvantage is outweighed by the ability to make complete prints.

To test, apply the patch and clear your cache. Try printing various
reports from Firefox. Printouts should look correct and be complete.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
all tests pass

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
CSS only change, no strings involved.
Tested with a saved SQL report 'select * from borrowers'.
Comment 9 Jared Camins-Esakov 2013-05-15 11:16:47 UTC
This patch has been pushed to master and 3.12.x.