| Summary: | Holds queue ignores item-level holds where only one items exists | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall <kyle.m.hall> |
| Component: | Hold requests | Assignee: | Kyle M Hall <kyle.m.hall> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P5 - low | CC: | bgkriegel, georgew, gmcharlt, melia, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 10311 - Holds queue ignores item-level holds where only one items exists
[Signed off] Bug 10311 - Holds queue ignores item-level holds where only one items exists Bug 10311 - Holds queue ignores item-level holds where only one items exists |
||
|
Description
Kyle M Hall
2013-05-22 13:52:29 UTC
Created attachment 18315 [details] [review] Bug 10311 - Holds queue ignores item-level holds where only one items exists If a record has only one item, and that item has one item-level hold on it, that hold will not show in the holds queue. Test Plan: 1) Create 1 record with 1 item at BranchA 2) Create an item-level hold for that item, for pickup at BranchA by a patron of BranchA 3) Run build_holds_queue.pl 4) View the holds queue for BranchA 5) Note the hold is not in there 6) Apply this patch 7) Re-run build_holds_queue.pl 8) View the holds queue again 9) Not that the hold is now there I've tested this patch on the VALNet production server and it works as expected. George Williams Created attachment 18359 [details] [review] [Signed off] Bug 10311 - Holds queue ignores item-level holds where only one items exists If a record has only one item, and that item has one item-level hold on it, that hold will not show in the holds queue. Test Plan: 1) Create 1 record with 1 item at BranchA 2) Create an item-level hold for that item, for pickup at BranchA by a patron of BranchA 3) Run build_holds_queue.pl 4) View the holds queue for BranchA 5) Note the hold is not in there 6) Apply this patch 7) Re-run build_holds_queue.pl 8) View the holds queue again 9) Not that the hold is now there Signed-off-by: George Williams <georgew@latahlibrary.org> I'm adding the sign off on behalf of George. Created attachment 18778 [details] [review] Bug 10311 - Holds queue ignores item-level holds where only one items exists If a record has only one item, and that item has one item-level hold on it, that hold will not show in the holds queue. Test Plan: 1) Create 1 record with 1 item at BranchA 2) Create an item-level hold for that item, for pickup at BranchA by a patron of BranchA 3) Run build_holds_queue.pl 4) View the holds queue for BranchA 5) Note the hold is not in there 6) Apply this patch 7) Re-run build_holds_queue.pl 8) View the holds queue again 9) Not that the hold is now there Signed-off-by: George Williams <georgew@latahlibrary.org> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Pushed to master. Thanks, Kyle! This patch has been pushed to 3.12.x, will be in 3.12.1. Great work Kyle! Pushed to 3.10.x, will be in 3.10.8 |