Summary: | Place a hold at time of ordering | ||
---|---|---|---|
Product: | Koha | Reporter: | Amit Gupta <amitddng135> |
Component: | Acquisitions | Assignee: | Amit Gupta <amitddng135> |
Status: | RESOLVED DUPLICATE | QA Contact: | |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | amitddng135, black23, chris, colin.campbell, jennie.evans, josef.moravec, koha, kyle, marjorie.barry-vila, mtompset, srdjan, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Place Hold on Order
Bug 10498 - Place Hold on Order |
Description
Amit Gupta
2013-06-20 05:20:26 UTC
Created attachment 19211 [details] [review] Place Hold on Order When creating an order, to have the option to place a hold against the ordered item. Test Plan: 1) Choose Systempreference AcqCreateItem to Create an item when placing an order. 2) Create an order. 3) Click on Modify link. 4) Reserve for tab will come enter the patron cardnumber or name and click on Place hold button. 5) Page will go to the request.pl and it will check the circulation rule. 6) Click on Place hold and return to order page. 7) It will redirect to the neworderempty.pl page. tested on a biblibre sandbox Applying: Bug 10498 - Place Hold on Order Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging acqui/neworderempty.pl CONFLICT (content): Merge conflict in acqui/neworderempty.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Auto-merging reserve/request.pl Failed to merge in the changes. Hi, I am not getting any error while applying patch on master( 061eb659267925388d1902987efaf275e536f953 ) Please see: git am -3 -i -s -u 0001-Bug-10498-Place-Hold-on-Order.patch Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all a Applying: Bug 10498 - Place Hold on Order root@amit-Inspiron-1545:/opt/kohaclone# Not having any problem applying this to a clean master branch CONFLICT (content): Merge conflict in reserve/request.pl Created attachment 22036 [details] [review] Bug 10498 - Place Hold on Order When creating an order, to have the option to place a hold against the ordered item. Test Plan: 1) Choose Systempreference AcqCreateItem to Create an item when placing an order. 2) Create an order. 3) Click on Modify link. 4) Reserve for tab will come enter the patron cardnumber or name and click on Place hold button. 5) Page will go to the request.pl and it will check the circulation rule. 6) Click on Place hold and return to order page. 7) It will redirect to the neworderempty.pl page. I got Global symbol "$messages" requires explicit package name at /home/srdjan/koha/dev/reserve/request.pl line 170. Global symbol "$warnings" requires explicit package name at /home/srdjan/koha/dev/reserve/request.pl line 172. Execution of /home/srdjan/koha/dev/reserve/request.pl aborted due to compilation errors. Yep, Syntax errors in the script Global symbol "$messages" requires explicit package name at reserve/request.pl line 170. Global symbol "$warnings" requires explicit package name at reserve/request.pl line 172. reserve/request.pl had compilation errors. This needs a rebase/rework, because this no longer applies cleanly. Hi Tompsett, I am working on same will rebase patch and send. Would be nice to have. Anybody working on this feature? +1 I think this would be a super helpful feature! *** This bug has been marked as a duplicate of bug 34300 *** |