Bug 10498 - Place a hold at time of ordering
Summary: Place a hold at time of ordering
Status: RESOLVED DUPLICATE of bug 34300
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Amit Gupta
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-20 05:20 UTC by Amit Gupta
Modified: 2023-10-10 11:57 UTC (History)
13 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Place Hold on Order (10.57 KB, patch)
2013-06-24 12:12 UTC, Amit Gupta
Details | Diff | Splinter Review
Bug 10498 - Place Hold on Order (10.56 KB, patch)
2013-10-17 16:42 UTC, Amit Gupta
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Amit Gupta 2013-06-20 05:20:26 UTC
When creating an order, to have the option to place a hold against the ordered item
Comment 1 Amit Gupta 2013-06-24 12:12:03 UTC Comment hidden (obsolete)
Comment 2 Koha Team University Lyon 3 2013-06-25 08:06:18 UTC
tested on a biblibre sandbox
Applying: Bug 10498 - Place Hold on Order
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging acqui/neworderempty.pl
CONFLICT (content): Merge conflict in acqui/neworderempty.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
Auto-merging reserve/request.pl
Failed to merge in the changes.
Comment 3 Amit Gupta 2013-06-25 08:43:08 UTC
Hi,

I am not getting any error while applying patch on master( 061eb659267925388d1902987efaf275e536f953 )

Please see:
git am -3 -i -s -u 0001-Bug-10498-Place-Hold-on-Order.patch 

Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all a
Applying: Bug 10498 - Place Hold on Order
root@amit-Inspiron-1545:/opt/kohaclone#
Comment 4 Colin Campbell 2013-07-01 07:52:00 UTC
Not having any problem applying this to a clean master branch
Comment 5 Srdjan Jankovic 2013-07-26 01:57:09 UTC
CONFLICT (content): Merge conflict in reserve/request.pl
Comment 6 Amit Gupta 2013-10-17 16:42:29 UTC
Created attachment 22036 [details] [review]
Bug 10498 - Place Hold on Order

When creating an order, to have the option to place a hold against the ordered
item.

Test Plan:
1) Choose Systempreference AcqCreateItem to Create an item when placing an order.
2) Create an order.
3) Click on Modify link.
4) Reserve for tab will come enter the patron cardnumber or name and click on
Place hold button.
5) Page will go to the request.pl and it will check the circulation rule.
6) Click on Place hold and return to order page.
7) It will redirect to the neworderempty.pl page.
Comment 7 Srdjan Jankovic 2013-10-28 01:40:42 UTC
I got

Global symbol "$messages" requires explicit package name at /home/srdjan/koha/dev/reserve/request.pl line 170.
Global symbol "$warnings" requires explicit package name at /home/srdjan/koha/dev/reserve/request.pl line 172.
Execution of /home/srdjan/koha/dev/reserve/request.pl aborted due to compilation errors.
Comment 8 Chris Cormack 2013-12-23 21:51:46 UTC
Yep,

Syntax errors in the script

Global symbol "$messages" requires explicit package name at reserve/request.pl line 170.
Global symbol "$warnings" requires explicit package name at reserve/request.pl line 172.
reserve/request.pl had compilation errors.
Comment 9 Mark Tompsett 2014-07-29 03:00:31 UTC
This needs a rebase/rework, because this no longer applies cleanly.
Comment 10 Amit Gupta 2014-07-29 03:25:26 UTC
Hi Tompsett,

I am working on same will rebase patch and send.
Comment 11 Marc Véron 2017-04-17 06:25:10 UTC
Would be nice to have. Anybody working on this feature?
Comment 12 Michal Denar 2020-01-05 20:55:05 UTC
+1
Comment 13 J. Evans 2020-06-16 17:05:52 UTC
I think this would be a super helpful feature!
Comment 14 Katrin Fischer 2023-10-10 11:57:27 UTC

*** This bug has been marked as a duplicate of bug 34300 ***