Summary: | three disused scripts in misc/cronjobs/stats should be removed | ||
---|---|---|---|
Product: | Koha | Reporter: | Galen Charlton <gmcharlt> |
Component: | Architecture, internals, and plumbing | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 10426 | ||
Attachments: |
Bug 10771: remove disused statistical reports cronjobs
Bug 10771: remove disused statistical reports cronjobs Bug 10771: remove disused statistical reports cronjobs |
Description
Galen Charlton
2013-08-20 19:03:28 UTC
Created attachment 20510 [details] [review] Bug 10771: remove disused statistical reports cronjobs This patch removes three cronjobs that are believed to be unused for the following reasons: [1] The commit message that introduces them indicates that they were written for a particular library. A staff member from that library has confirmed that they are not in use. [2] The scripts have received essentially no patches since they were introduced except for being caught up in a broader code-improvement patch. [3] They refer to a column that no longer exists in biblioitems. [4] They no longer adhere to guidelines for command-line utilities, and there's been no sign that anybody has felt the urge to correct that. [5] They are not referenced by another code or the manual, and the mailing list archives do not include any substantive discussion of their use. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Created attachment 20813 [details] [review] Bug 10771: remove disused statistical reports cronjobs This patch removes three cronjobs that are believed to be unused for the following reasons: [1] The commit message that introduces them indicates that they were written for a particular library. A staff member from that library has confirmed that they are not in use. [2] The scripts have received essentially no patches since they were introduced except for being caught up in a broader code-improvement patch. [3] They refer to a column that no longer exists in biblioitems. [4] They no longer adhere to guidelines for command-line utilities, and there's been no sign that anybody has felt the urge to correct that. [5] They are not referenced by another code or the manual, and the mailing list archives do not include any substantive discussion of their use. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 20834 [details] [review] Bug 10771: remove disused statistical reports cronjobs This patch removes three cronjobs that are believed to be unused for the following reasons: [1] The commit message that introduces them indicates that they were written for a particular library. A staff member from that library has confirmed that they are not in use. [2] The scripts have received essentially no patches since they were introduced except for being caught up in a broader code-improvement patch. [3] They refer to a column that no longer exists in biblioitems. [4] They no longer adhere to guidelines for command-line utilities, and there's been no sign that anybody has felt the urge to correct that. [5] They are not referenced by another code or the manual, and the mailing list archives do not include any substantive discussion of their use. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master. |