Description
Mason James
2013-09-05 04:09:07 UTC
Created attachment 20790 [details] [review] Bug 10823 - add class info to enumchron data in detail.tt, for better styling Marking this 'Needs Signoff', as it has a patch, but we need to check if the change is still needed and we might prefer using a <span> instead of a <div> tag. After applying this patch all info in the enumchron column in the staff client disappeared for me ... Comment on attachment 20790 [details] [review] Bug 10823 - add class info to enumchron data in detail.tt, for better styling Review of attachment 20790 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ +513,5 @@ > + [% END %] > + [% IF ( itemloo.serialseq ) %] > + <div class="serialseq"> -- [% itemloo.serialseq %]</div> > + [% END %] > + [% IF ( itemloo.publisheddate ) %] These say 'itemloo' vs. 'item' in the previous code. This is why it disappeared for Nicole. Created attachment 26709 [details] [review] Bug 10823 - add class info to enumchron data in detail.tt, for better styling By adding div tags, styling ability can be improved. This included serialseq and pubdate classes. Comment on attachment 26709 [details] [review] Bug 10823 - add class info to enumchron data in detail.tt, for better styling Hm, why a div and not a span? Created attachment 27073 [details] [review] Bug 10823 - add class info to enumchron data in detail.tt, for better styling By adding span tags, styling ability can be improved. This included serialseq and pubdate classes. This update reflects suggestions by Katrin (comment #7) and a conversation with oleonard our resident expert. (http://irc.koha-community.org/koha/2014-04-03#i_1491135) Created attachment 27074 [details] [review] Bug 10823 - Follow up to correct problem with origin patch This fixes the itemloo's by changing them to item. This update reflects suggestions by Katrin (comment #7) and a conversation with oleonard our resident expert. (http://irc.koha-community.org/koha/2014-04-03#i_1491135) Created attachment 27075 [details] [review] Bug 10823 - Follow up to correct problem with origin patch This fixes the itemloo's by changing them to item. This restores proper logic for the --'s. This update reflects suggestions by Katrin (comment #7) and a conversation with oleonard our resident expert. (http://irc.koha-community.org/koha/2014-04-03#i_1491135) Created attachment 27085 [details] [review] Bug 10823 - Follow up to add <span> to '--' Created attachment 27086 [details] [review] Bug 10823 - Follow up to correct problem with origin patch This fixes the itemloo's by changing them to item. This restores proper logic for the --'s. This update reflects suggestions by Katrin (comment #7) and a conversation with oleonard our resident expert. (http://irc.koha-community.org/koha/2014-04-03#i_1491135) Signed-off-by: Mason James <mtj@kohaaloha.com> Created attachment 27087 [details] [review] Bug 10823 - Follow up to add <span> to '--' bug needs sign-off on patch 1 and 3... Created attachment 27091 [details] [review] Bug 10823 - add class info to enumchron data in detail.tt, for better styling squashing 3 patches, and rebasing after 10825 Created attachment 27092 [details] [review] Bug 10823 - add class info to enumchron data in detail.tt, for better styling squashing 3 patches, and rebasing after 10825 Created attachment 27103 [details] [review] Bug 10823 - add class info to enumchron data in detail.tt, for better styling Bug 10825 removes a duplicate (enumchron==serialseq). This patch was developed on top of it. It properly styles the elements. These include: - items.enumchron - the separator used - serial.serialseq - items.publisheddate As per Katrin's and Owen's suggestion, <span> was used instead of <div>. (See comment #7 and http://irc.koha-community.org/koha/2014-04-03#i_1491135) TEST PLAN --------- 1) Apply patch 10825 2) Find a biblio where the enumchron and serialseq are different. -- in MySQL: SELECT items.biblionumber,items.enumchron,serial.serialseq FROM items,serial,serialitems WHERE items.itemnumber=serilaitems.itemnumber AND serialitems.serialid=serial.serialid; 3) In the staff client, view the source for that item. -- It should be one class for the entire <td> cell. 4) Apply patch 10823 5) Refresh the page 6) Look at the source for that item again. -- It should have <span> tags around the 4 things listed above. 7) Run the koha qa test tools. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Since there was lots of squashing and rebasing, could you please test and sign this off as well, Mason? Created attachment 27536 [details] [review] [SIGNED-OFF] Bug 10823 - add class info to enumchron data in detail.tt, for better styling Bug 10825 removes a duplicate (enumchron==serialseq). This patch was developed on top of it. It properly styles the elements. These include: - items.enumchron - the separator used - serial.serialseq - items.publisheddate As per Katrin's and Owen's suggestion, <span> was used instead of <div>. (See comment #7 and http://irc.koha-community.org/koha/2014-04-03#i_1491135) TEST PLAN --------- 1) Apply patch 10825 2) Find a biblio where the enumchron and serialseq are different. -- in MySQL: SELECT items.biblionumber,items.enumchron,serial.serialseq FROM items,serial,serialitems WHERE items.itemnumber=serilaitems.itemnumber AND serialitems.serialid=serial.serialid; 3) In the staff client, view the source for that item. -- It should be one class for the entire <td> cell. 4) Apply patch 10823 5) Refresh the page 6) Look at the source for that item again. -- It should have <span> tags around the 4 things listed above. 7) Run the koha qa test tools. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Since there was lots of squashing and rebasing, could you please test and sign this off as well, Mason? Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 27650 [details] [review] [PASSED QA] Bug 10823 - add class info to enumchron data in detail.tt, for better styling Bug 10825 removes a duplicate (enumchron==serialseq). This patch was developed on top of it. It properly styles the elements. These include: - items.enumchron - the separator used - serial.serialseq - items.publisheddate As per Katrin's and Owen's suggestion, <span> was used instead of <div>. (See comment #7 and http://irc.koha-community.org/koha/2014-04-03#i_1491135) TEST PLAN --------- 1) Apply patch 10825 2) Find a biblio where the enumchron and serialseq are different. -- in MySQL: SELECT items.biblionumber,items.enumchron,serial.serialseq FROM items,serial,serialitems WHERE items.itemnumber=serilaitems.itemnumber AND serialitems.serialid=serial.serialid; 3) In the staff client, view the source for that item. -- It should be one class for the entire <td> cell. 4) Apply patch 10823 5) Refresh the page 6) Look at the source for that item again. -- It should have <span> tags around the 4 things listed above. 7) Run the koha qa test tools. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Since there was lots of squashing and rebasing, could you please test and sign this off as well, Mason? Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template change only, no regression found. Using [%- -%] could improve readability of HTML source code. Pushed to master. Thanks, Mason! |