Summary: | about->timeline broken on upgraded Koha | ||
---|---|---|---|
Product: | Koha | Reporter: | Mason James <mtj> |
Component: | About | Assignee: | Mason James <mtj> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | bgkriegel, gmcharlt, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8911 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 10915 - about->timeline broken on upgraded Koha
Bug 10915 - about->timeline broken on upgraded Koha before/after pic Bug 10915 - about->timeline broken on upgraded Koha Bug 10915: (Possible) QA followup - warn if cannot read history.txt |
Description
Mason James
2013-09-19 12:18:01 UTC
Created attachment 21237 [details] [review] Bug 10915 - about->timeline broken on upgraded Koha Created attachment 21238 [details] [review] Bug 10915 - about->timeline broken on upgraded Koha Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 21239 [details]
before/after pic
QA Comment: Small fix. Works. Looks good to me. No complaints from qa tools. Passed QA Created attachment 21251 [details] [review] Bug 10915 - about->timeline broken on upgraded Koha Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Fixes dev and standard installs without docdic tag in koha-conf.xml. Doesn't break when docdir present either. Warning still present on packages install that didn't add the docdir definition in koha-conf.xml Created attachment 21253 [details] [review] Bug 10915: (Possible) QA followup - warn if cannot read history.txt This patch makes about.pl test if success opening history.txt, and shows a convenient warning to the end user. No more warnings in the logs (about.pl: readline() on closed filehandle $file at /usr/share/koha/intranet/cgi-bin/about.pl line 166) and better problem solving information for the end user. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Pushed to master. Thanks, Mason! Pushed to 3.10.x, will be in 3.10.12 |