Summary: | 710$a with 710$b (subordinate unit) present shows wrong (XSLT) | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Templates | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | gitbot, kyle, paola.rossi |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
sample
Bug 10957: 710$a with 710$b (subordinate unit) present shows wrong (XSLT) 710$a with 710$b (subordinate unit) present shows wrong (XSLT) |
Created attachment 21501 [details] [review] Bug 10957: 710$a with 710$b (subordinate unit) present shows wrong (XSLT) This patch fixes a visualization problem with XSLTs for 710$a and 710$b in both Intranet and OPAC interfaces, on both search results and detail pages. To test: - Create two bibliographic records. a) One with only 710$a b) One with 710$a and 710$b - Do a search on OPAC and Intranet and see 710$a and 710$b are put together without a space in the middle. - Enter the detail page (in both interfaces) and see the problem is present there too. - Apply the patch - It should look as expeced. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Patch applied cleanly, go forth and signoff Created attachment 21941 [details] [review] 710$a with 710$b (subordinate unit) present shows wrong (XSLT) I sign off the patch Hi Tomas, what i did was using an authority with $a $b $b (as $b is noted as repeatable). The generated string looked like this: Staff detail: a. b, -- c. Staff result: a. b I wonder about the different generation of the display in result and detail. I think that the punctuation should be cataloged with the record, so maybe -- would not be needed. But, I am not really sure how this should look like. Note: a separeate patch will be needed for the bootstrap OPAC. Leaving as 'signed off', but please comment. Question: does this need a unimarc followup, or does this bug not affect unimarc? I think the fields and XSLT stylesheets for UNIMARC are quite different, so I think this could go with a MARC21 patch only. Tomas, could you take a look at my comments in comment 4? (In reply to Katrin Fischer from comment #4) > Hi Tomas, > > what i did was using an authority with $a $b $b (as $b is noted as > repeatable). The generated string looked like this: > > Staff detail: > a. b, -- c. > > Staff result: > a. b > > I wonder about the different generation of the display in result and detail. > I think that the punctuation should be cataloged with the record, so maybe > -- would not be needed. But, I am not really sure how this should look like. > > Note: a separeate patch will be needed for the bootstrap OPAC. > > Leaving as 'signed off', but please comment. Jared told me on IRC it was customary to use -- for $c. In any case, I just left it as it was before (if i recall). |
Created attachment 21494 [details] sample If both 710$a and 710$b are present they are pasted together without punctuation or space between.