| Summary: | DT: default entry is 20 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 | ||
| Change sponsored?: | --- | Patch complexity: | Medium patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 11555 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 11605: default entry is 20 for all tables using datatables
[SIGNED-OFF] Bug 11605: default entry is 20 for all tables using datatables Bug 11605: Fix regression Bug 11605: default entry is 20 for all tables using datatables Bug 11605: Fix regression Bug 11605: default entry is 20 for all tables using datatables Bug 11605: Fix regression |
||
|
Description
Jonathan Druart
2014-01-24 11:18:02 UTC
Created attachment 24672 [details] [review] Bug 11605: default entry is 20 for all tables using datatables The default entry is 20 and can be apply to all tables. Bug 11555 apply the menu entries to all tables, redefining it is uesless and can be removed. Test plan: Test pages impacted by this patch and verify there is no regression on the tables. Created attachment 24897 [details] [review] [SIGNED-OFF] Bug 11605: default entry is 20 for all tables using datatables The default entry is 20 and can be apply to all tables. Bug 11555 apply the menu entries to all tables, redefining it is uesless and can be removed. Test plan: Test pages impacted by this patch and verify there is no regression on the tables. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Comment on attachment 24672 [details] [review] Bug 11605: default entry is 20 for all tables using datatables Temporarily unobsoleting just for a short while. No worries :) Comment on attachment 24672 [details] [review] Bug 11605: default entry is 20 for all tables using datatables No. Doesn't work either.. Applying: Bug 11605: default entry is 20 for all tables using datatables fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/js/datatables.js). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11605: default entry is 20 for all tables using datatables Hello Marcel, This patch depends on bug 11555 and applies correctly. (In reply to Jonathan Druart from comment #6) > Hello Marcel, > This patch depends on bug 11555 and applies correctly. OK Sorry, probably not seen :) Created attachment 24997 [details] [review] Bug 11605: Fix regression Bug 11314 overrides the iDisplayLength and aLengthMenu values and should be kept. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 24998 [details] [review] Bug 11605: default entry is 20 for all tables using datatables The default entry is 20 and can be apply to all tables. Bug 11555 apply the menu entries to all tables, redefining it is uesless and can be removed. Test plan: Test pages impacted by this patch and verify there is no regression on the tables. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 24999 [details] [review] Bug 11605: Fix regression Bug 11314 overrides the iDisplayLength and aLengthMenu values and should be kept. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 25133 [details] [review] Bug 11605: default entry is 20 for all tables using datatables The default entry is 20 and can be apply to all tables. Bug 11555 apply the menu entries to all tables, redefining it is uesless and can be removed. Test plan: Test pages impacted by this patch and verify there is no regression on the tables. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 25134 [details] [review] Bug 11605: Fix regression Bug 11314 overrides the iDisplayLength and aLengthMenu values and should be kept. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master, along with a follow-up that extends the defaults to the new staged MARC record management table. Thanks, Jonathan! |