Bug 11314 - Restore ability to see only 5 entries on parcel.pl
Summary: Restore ability to see only 5 entries on parcel.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Kyle M Hall
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-27 17:40 UTC by Kyle M Hall
Modified: 2014-12-07 20:05 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11314 - Restore ability to see only 5 entries on parcel.pl (2.13 KB, patch)
2013-11-27 17:41 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 11314 - Restore ability to see only 5 entries on parcel.pl (2.40 KB, patch)
2014-01-20 03:28 UTC, David Cook
Details | Diff | Splinter Review
Bug 11314 - Restore ability to see only 5 entries on parcel.pl (2.46 KB, patch)
2014-01-24 14:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11314: Make "All" translatable (1.12 KB, patch)
2014-01-24 14:26 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2013-11-27 17:40:00 UTC
Bug 9130 removed the ability to limit the tables on parcel.pl to 5 rows, as well as the "sticky" feature. It is trivial to restore this functionality. These datatables are already using bStateSave, so are they are "sticky" already. The only part left is to enable the ability to limit the table to 5 rows at a time.
Comment 1 Kyle M Hall 2013-11-27 17:41:34 UTC Comment hidden (obsolete)
Comment 2 David Cook 2014-01-20 03:28:39 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-01-24 14:26:32 UTC
Created attachment 24692 [details] [review]
Bug 11314 - Restore ability to see only 5 entries on parcel.pl

Bug 9130 removed the ability to limit the tables on parcel.pl to 5 rows,
as well as the "sticky" feature. It is trivial to restore this
functionality. These datatables are already using bStateSave, so are
they are "sticky" already. The only part left is to enable the
ability to limit the table to 5 rows at a time.

Test Plan:
1) Apply this patch
2) Browse to parcel.pl
3) Note the default rows count is still 10
4) Note the option to limit the row count to 5

Signed-off-by: David Cook <dcook@prosentient.com.au>

Works as described.

Double-checked that the "sticky" feature is still in place thanks
to bStateSave.

I didn't notice a difference due to iDisplayLength being added, but
the extra option of "5" to the list is there.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Jonathan Druart 2014-01-24 14:26:38 UTC
Created attachment 24693 [details] [review]
Bug 11314: Make "All" translatable

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Jonathan Druart 2014-01-24 14:29:57 UTC
I am not sure to understand what bStateSave does.
If I click on the "Filter" button (on the left side of parcel.pl), the value become again the default value (10).
Since bug 11555 and bug 11605 make "All" translatable, I added a followup to keep the translation on this page.

Marked as Passed QA.
Comment 6 Galen Charlton 2014-01-26 15:43:18 UTC
Pushed to master.  Thanks, Kyle!
Comment 7 Fridolin Somers 2014-04-23 17:23:09 UTC
Patches pushed to 3.14.x, will be in 3.14.06