|
Description
Kyle M Hall (khall)
2014-02-12 12:47:33 UTC
Created attachment 25204 [details] [review] Bug 11746 - Add edit item links to record details page In order to edit a specific item right now, one must select the edit pulldown, then choose edit items, the click the edit link for the particular item the librarian wishes to edit. It would be much more convenient to have an edit link for each specific item in the items table on the record details page. Test Plan: 1) Apply this patch 2) View the record details for a record with items 3) Click the edit link for a particular item 4) Note that you are taken immediately to the item editor for this particular item Hi Kyle I would also like a more direct way to edit the item. I am not sure if this new Edit column not deviates from the current design with the check buttons for delete or batch modify, and the link on barcode. But it works.. Will leave this problem to the QAer on duty :) Created attachment 25206 [details] [review] Bug 11746 - Add edit item links to record details page In order to edit a specific item right now, one must select the edit pulldown, then choose edit items, the click the edit link for the particular item the librarian wishes to edit. It would be much more convenient to have an edit link for each specific item in the items table on the record details page. Test Plan: 1) Apply this patch 2) View the record details for a record with items 3) Click the edit link for a particular item 4) Note that you are taken immediately to the item editor for this particular item Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> The edit link should not be shown to users who don't have permission to edit. Created attachment 25222 [details] [review] Bug 11746 [QA Followup] - Add edit item links to record details page (In reply to Owen Leonard from comment #4) > The edit link should not be shown to users who don't have permission to edit. Wow, I can't believe I forgot to check permissions! Followup submitted! Kyle Tested it and it works as described. Great job, Kyle! Created attachment 25225 [details] [review] Bug 11746 [QA Followup 2] - Disable sorting on Edit column Created attachment 25226 [details] [review] Bug 11746 - Add edit item links to record details page Created attachment 25227 [details] [review] Bug 11746 [QA Followup] - Add edit item links to record details page Created attachment 25228 [details] [review] Bug 11746 [QA Followup 2] - Disable sorting on Edit column I got a JS error on goind on catalogue/detail.pl DataTables warning (table id = 'DataTables_Table_0'): Requested unknown parameter '9' from the data source for row 0 If there is no course reserve, there are no 10 columns. Marked as Failed QA. Created attachment 25579 [details] [review] Bug 11746 [QA Followup 3] Created attachment 25607 [details] [review] Bug 11746 - Add edit item links to record details page In order to edit a specific item right now, one must select the edit pulldown, then choose edit items, the click the edit link for the particular item the librarian wishes to edit. It would be much more convenient to have an edit link for each specific item in the items table on the record details page. Test Plan: 1) Apply this patch 2) View the record details for a record with items 3) Click the edit link for a particular item 4) Note that you are taken immediately to the item editor for this particular item Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Havilah Lyon <havilah@aflibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 25608 [details] [review] Bug 11746 [QA Followup] - Add edit item links to record details page Signed-off-by: Havilah Lyon <havilah@aflibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 25609 [details] [review] Bug 11746 [QA Followup 2] - Disable sorting on Edit column Signed-off-by: Havilah Lyon <havilah@aflibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 25610 [details] [review] Bug 11746 [QA Followup 3] Fix Javascript error DataTables warning (table id = 'DataTables_Table_0'): Requested unknown parameter '9' from the data source for row 0 Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master. Thanks, Kyle! However, I am declining to push the second and third follow-ups, as they are not comprehensive enough -- if a staff user lacks permission to edit items, and spine label printing is off, and there are no analytics, the last column that would be made non-sortable would be an item information column. Leaving the edit column sortable for now is the lesser evil. I will open a new bug for setting up an actions column in the holdings table. (In reply to Galen Charlton from comment #18) > I will open a new bug for setting up an actions column in the holdings table. Bug 11851. *** Bug 11840 has been marked as a duplicate of this bug. *** Pushed to 3.14.x, will be in 3.14.08 (Like in master, concerns only the 2 first patches) |