Summary: | Merge circ-menu.tt and a circ-menu.inc | ||
---|---|---|---|
Product: | Koha | Reporter: | Galen Charlton <gmcharlt> |
Component: | Architecture, internals, and plumbing | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | bgkriegel, chris, jonathan.druart, pasi.kallinen, tomascohen, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13543 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13583 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13582 |
||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 11804: Remove unused circ-menu.tt
[SIGNED-OFF] Bug 11804: Remove unused circ-menu.tt Bug 14409: Remove references to circ-menu.tt Bug 11804: Remove unused circ-menu.tt Bug 11804: Remove references to circ-menu.tt |
Description
Galen Charlton
2014-02-20 19:29:55 UTC
Some additional differences have creeped into the files: -use of INCLUDE 'patron-title.inc' vs. hard-coded patron title. -IF-checking picture vs. checking has_picture. -TT filtering borrowernumber with uri vs. not filtering. Other stuff that could be improved: -Hard-coded css styles should be moved into external stylesheets. -patroncategory and patronlibrary do not separate field description from the field content, so impossible to style separately. Good catch, thx for linking to the other bug paxed. This bug seems to be resolved. Verifyed on current master: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt line 230: [% INCLUDE 'circ-menu.inc' %] koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt line 175: [% INCLUDE 'circ-menu.inc' %] git grep 'circ-menu.tt' members/boraccount.pl:#workaround for Bug 4041 to get rid of duplicated code in circ-menu.tt, use circ-menu.inc instad members/pay.pl: #workaround for Bug 4041 to get rid of duplicated code in circ-menu.tt, use circ-menu.inc instad members/paycollect.pl:#workaround for Bug 4041 to get rid of duplicated code in circ-menu.tt, use circ-menu.inc instad (...) Hi Mark, I think you are right, but it looks like we didn't remove the file. I will submit a patch. Created attachment 39932 [details] [review] Bug 11804: Remove unused circ-menu.tt The formerly used circ-menu.tt is no longer referenced in the templates and can be removed. To test: - Verify all tabs in the patron account still work as they should. - git grep circ-menu.tt Created attachment 40316 [details] [review] [SIGNED-OFF] Bug 11804: Remove unused circ-menu.tt The formerly used circ-menu.tt is no longer referenced in the templates and can be removed. To test: - Verify all tabs in the patron account still work as they should. - git grep circ-menu.tt Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No problems on patron pages, no more circ-menu.tt No errors Created attachment 40318 [details] [review] Bug 14409: Remove references to circ-menu.tt Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Created attachment 40319 [details] [review] Bug 11804: Remove unused circ-menu.tt The formerly used circ-menu.tt is no longer referenced in the templates and can be removed. To test: - Verify all tabs in the patron account still work as they should. - git grep circ-menu.tt Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No problems on patron pages, no more circ-menu.tt No errors Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Created attachment 40320 [details] [review] Bug 11804: Remove references to circ-menu.tt Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Patches pushed to master. Thanks Katrina and Jonathan! Pushed to 3.20.x will be in 3.20.2 |