| Summary: | Fix Armenian language description | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Bernardo Gonzalez Kriegel <bgkriegel> |
| Component: | I18N/L10N | Assignee: | Bugs List <koha-bugs> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | f.demians, fridolin.somers, gmcharlt, h.meissner.82 |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9056 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11568 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11393 |
||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 11973 - Fix Armenian language description
Bug 11973 - Fix Armenian language description Bug 11973 - Fix Armenian language description [PASSED QA] Bug 11973 - Fix Armenian language description |
||
|
Description
Bernardo Gonzalez Kriegel
2014-03-20 11:42:42 UTC
Created attachment 26482 [details] [review] Bug 11973 - Fix Armenian language description This patch fix Armenian language description To test: 1) Do a fake translation to Armenian, mkdir koha-tmpl/intranet-tmpl/prog/hy-Armn 2) Go to Administration > System preferences > I18N/L10N 3) Armenian description looks like the second string in Bug description 4) Apply the patch 5) Run updatedatabase.pl 6) Reload page, now description look as first string in Bug description (it's the sixth letter, similar to 't') Created attachment 26493 [details] [review] Bug 11973 - Fix Armenian language description This patch fix Armenian language description To test: 1) Do a fake translation to Armenian, mkdir koha-tmpl/intranet-tmpl/prog/hy-Armn 2) Go to Administration > System preferences > I18N/L10N 3) Armenian description looks like the second string in Bug description 4) Apply the patch 5) Run updatedatabase.pl 6) Reload page, now description look as first string in Bug description (it's the sixth letter, similar to 't') Ammended patch, wrong column. Created attachment 26508 [details] [review] Bug 11973 - Fix Armenian language description This patch fix Armenian language description To test: 1) Do a fake translation to Armenian, mkdir koha-tmpl/intranet-tmpl/prog/hy-Armn 2) Go to Administration > System preferences > I18N/L10N 3) Armenian description looks like the second string in Bug description 4) Apply the patch 5) Run updatedatabase.pl 6) Reload page, now description look as first string in Bug description (it's the sixth letter, similar to 't') Ammended patch, wrong column. Signed-off-by: Holger Meißner <h.meissner.82@web.de> Those letters look so similar. I increased the font size and did a screenshot before and after, to be sure. :D This patch fixes the English sql file, but the wrong string still appears in the translated SQL files: installer/data/mysql/de-DE/mandatory/subtag_registry.sql 86 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); installer/data/mysql/es-ES/mandatory/subtag_registry.sql 74 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); installer/data/mysql/it-IT/necessari/subtag_registry.sql 76 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); installer/data/mysql/nb-NO/1-Obligatorisk/subtag_registry.sql 95 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); installer/data/mysql/pl-PL/mandatory/subtag_registry.sql 74 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); installer/data/mysql/ru-RU/mandatory/subtag_registry.sql 74 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); installer/data/mysql/uk-UA/mandatory/subtag_registry.sql 74 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); We really should only maintain the language files once, as they contain all the translations. Created attachment 26517 [details] [review] [PASSED QA] Bug 11973 - Fix Armenian language description This patch fix Armenian language description To test: 1) Do a fake translation to Armenian, mkdir koha-tmpl/intranet-tmpl/prog/hy-Armn 2) Go to Administration > System preferences > I18N/L10N 3) Armenian description looks like the second string in Bug description 4) Apply the patch 5) Run updatedatabase.pl 6) Reload page, now description look as first string in Bug description (it's the sixth letter, similar to 't') Ammended patch, wrong column. Signed-off-by: Holger Meißner <h.meissner.82@web.de> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch fixes the English sample file for translations and includes a database update to correct the string in existing installations. Passes all tests and QA script. I have added some other related bugs. My suggestion would be, that we first fix the English file as reference and then either - copy the corrected English file for all translated installers - or better: move it out of the language specific installer directories (like syspref.sql) Pushed to master. Thanks, Bernardo! (In reply to Katrin Fischer from comment #7) > I have added some other related bugs. My suggestion would be, that we first > fix the English file as reference and then either > - copy the corrected English file for all translated installers > - or better: move it out of the language specific installer directories > (like syspref.sql) I did a patch for your last suggestion, changed Installer.pm and did a install to test it. It worked Later I changed my mind and did Bug 12017. I think it's better to have languages descriptions out of database, at last for translations. Hi Bernardo, thx a lot for looking into this. I think one of the reasons it wasn't moved to the templates was that we don't want to translate, but show the native description for languages - not sure how to do that with the translation system. Also in advanced search we show the native and the translated description together. Katrin, I did a new version. Now all is native, and advanced search shows translations. All in templates. Pushed to 3.14.x, will be in 3.14.08 |