Summary: | Deduplicate TT code for account payments | ||
---|---|---|---|
Product: | Koha | Reporter: | paxed <pasi.kallinen> |
Component: | Templates | Assignee: | paxed <pasi.kallinen> |
Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, katrin.fischer, magnus |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: | Bug 12186: Deduplicate TT code for account payments |
Description
paxed
2014-05-05 10:02:38 UTC
And there should probably be a space between "Payment" and "thanks"? Payment, thanks not Payment,thanks There are also bugs 12165 for adding the code to bootstrap and bug 12166. There are still some things that need to be added to the account descriptions before they will cover all cases. Created attachment 78241 [details] [review] Bug 12186: Deduplicate TT code for account payments Instead of using the same accounttype switch statement multiple times, just use the accounttype include file. Test plan: 1) Apply patch 2) Go to Patron's Fines 3) in the Pay fines -tab, check that the description shows correctly 4) in the Account -tab, click on the "Print" after the entries and check that the description shows correctly, both for invoices and fees. Patch no longer applies 8-( Looks to me like these files had a significant amount of change over the last year or so, so maybe this change is not required any more? I believe this has been solved by other patches/developments. We have now 2 include files, one for OPAC and one for the staff interface: koha-tmpl/intranet-tmpl/prog/en/includes/accounts.inc: [%- CASE 'RESERVE_EXPIRED' -%]<span>Hold waiting too long</span> koha-tmpl/opac-tmpl/bootstrap/en/includes/accounts.inc: [%- CASE 'RESERVE_EXPIRED' -%]<span>Hold waiting too long</span> |