Bug 12294

Summary: Revert BZ9372
Product: Koha Reporter: Sophie MEYNIEUX <sophie.meynieux>
Component: NoticesAssignee: Sophie MEYNIEUX <sophie.meynieux>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: bgkriegel, kyle, m.de.rooy, tomascohen
Version: Main   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12300
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 12294 : Cancel replacing carriage return with <br /> in printed html file as <br /> is needed in model for email notices when html format is checked
[SIGNED-OFF] Bug 12294 : Cancel replacing carriage return on notices
[PASSED QA] Bug 12294 : Cancel replacing carriage return on notices

Description Sophie MEYNIEUX 2014-05-20 15:14:33 UTC
Because of the decision taken for BZ11173, to write explicitly <br /> in notices when html format is used, BZ9372 that replaces carriage return with <br /> in html file is not necessary. It induces double <br /> fro each line.
Comment 1 Sophie MEYNIEUX 2014-05-20 15:56:32 UTC Comment hidden (obsolete)
Comment 2 Sophie MEYNIEUX 2014-05-20 16:11:34 UTC
Test plan :
* define an OVERDUE notice with html activated, with <br /> at each end of line
* make sur you've got some borrowers with overdues meeting your notices triggering rules (some with valid email and others without)
* run overdue_notices.pl -html to generate html files for borrowers without email

Without patch
* email notifications are correctly formated as html content, with one <br /> at each end of line
* in html file, <br /> is duplicated at each end of line

With patch
* nothing changes for email notification
* html file is correctly formatted with only one <br /> at each end of line
Comment 3 Bernardo Gonzalez Kriegel 2014-06-22 23:53:04 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2014-07-11 16:03:11 UTC
Created attachment 29652 [details] [review]
[PASSED QA] Bug 12294 : Cancel replacing carriage return on notices

Cancel replacing carriage return with <br /> in printed html file as <br /> is needed in model for email notices when html format is checked

Test plan :
* define an OVERDUE notice with html activated, with <br /> at each end of line
* make sur you've got some borrowers with overdues meeting your notices triggering rules (some with valid email and others without)
* run overdue_notices.pl -html to generate html files for borrowers without email

Without patch
* email notifications are correctly formated as html content, with one <br /> at each end of line
* in html file, <br /> is duplicated at each end of line

With patch
* nothing changes for email notification
* html file is correctly formatted with only one <br /> at each end of line

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Copied test plan from comment.
No errors

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Kyle M Hall 2014-07-11 16:05:51 UTC
My only concern with this patch is the fact that libraries have taken into account this bug when crafting notices. However, given that this is a whitespace issue, I think a release note would be adequate.
Comment 6 Tomás Cohen Arazi 2014-07-27 14:24:10 UTC
Patch pushed to master.

Thanks Sophie!

Note: I'll add a reference to this in the release notes as Kyle proposed.