| Summary: | Revert BZ9372 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Sophie MEYNIEUX <sophie.meynieux> |
| Component: | Notices | Assignee: | Sophie MEYNIEUX <sophie.meynieux> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | bgkriegel, kyle, m.de.rooy, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12300 |
||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 12294 : Cancel replacing carriage return with <br /> in printed html file as <br /> is needed in model for email notices when html format is checked
[SIGNED-OFF] Bug 12294 : Cancel replacing carriage return on notices [PASSED QA] Bug 12294 : Cancel replacing carriage return on notices |
||
|
Description
Sophie MEYNIEUX
2014-05-20 15:14:33 UTC
Created attachment 28374 [details] [review] Bug 12294 : Cancel replacing carriage return with <br /> in printed html file as <br /> is needed in model for email notices when html format is checked Test plan : * define an OVERDUE notice with html activated, with <br /> at each end of line * make sur you've got some borrowers with overdues meeting your notices triggering rules (some with valid email and others without) * run overdue_notices.pl -html to generate html files for borrowers without email Without patch * email notifications are correctly formated as html content, with one <br /> at each end of line * in html file, <br /> is duplicated at each end of line With patch * nothing changes for email notification * html file is correctly formatted with only one <br /> at each end of line Created attachment 29151 [details] [review] [SIGNED-OFF] Bug 12294 : Cancel replacing carriage return on notices Cancel replacing carriage return with <br /> in printed html file as <br /> is needed in model for email notices when html format is checked Test plan : * define an OVERDUE notice with html activated, with <br /> at each end of line * make sur you've got some borrowers with overdues meeting your notices triggering rules (some with valid email and others without) * run overdue_notices.pl -html to generate html files for borrowers without email Without patch * email notifications are correctly formated as html content, with one <br /> at each end of line * in html file, <br /> is duplicated at each end of line With patch * nothing changes for email notification * html file is correctly formatted with only one <br /> at each end of line Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Copied test plan from comment. No errors Created attachment 29652 [details] [review] [PASSED QA] Bug 12294 : Cancel replacing carriage return on notices Cancel replacing carriage return with <br /> in printed html file as <br /> is needed in model for email notices when html format is checked Test plan : * define an OVERDUE notice with html activated, with <br /> at each end of line * make sur you've got some borrowers with overdues meeting your notices triggering rules (some with valid email and others without) * run overdue_notices.pl -html to generate html files for borrowers without email Without patch * email notifications are correctly formated as html content, with one <br /> at each end of line * in html file, <br /> is duplicated at each end of line With patch * nothing changes for email notification * html file is correctly formatted with only one <br /> at each end of line Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Copied test plan from comment. No errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> My only concern with this patch is the fact that libraries have taken into account this bug when crafting notices. However, given that this is a whitespace issue, I think a release note would be adequate. Patch pushed to master. Thanks Sophie! Note: I'll add a reference to this in the release notes as Kyle proposed. |